Add frozen_string_literal comments and enable RuboCop rule #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbrictson
commented
May 24, 2024
Comment on lines
+25
to
+26
| Style/FrozenStringLiteralComment: | ||
| Enabled: false |
There was a problem hiding this comment.
🗒️ Style/FrozenStringLiteralComment leads to undesirable results in ERB files, so I've disabled it in the context of erb_lint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently Ruby 4 will freeze string literals by default. In preparation for that breaking change, Ruby 3.4 will issue a warning when string literals are mutated.
To prepare nextgen and nextgen-generated apps for the Ruby 4 future, I've added the
frozen_string_literalcomment to all files to opt into this behavior. For apps that opt into RuboCop, I've enabled theStyle/FrozenStringLiteralCommentrule by default as well.