Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent naming of PDF options #3

Closed
rossj opened this issue Mar 17, 2015 · 1 comment
Closed

Inconsistent naming of PDF options #3

rossj opened this issue Mar 17, 2015 · 1 comment

Comments

@rossj
Copy link
Contributor

rossj commented Mar 17, 2015

The readme file lists PDF options with a pdf prefix, however; the fillPdfOptions() method looks for options without the prefix. I would be happy to make a PR, I just need to know if you want to update the README or the option parser.

Thanks!
@mattcg
Copy link
Contributor

mattcg commented Mar 17, 2015

Nicely spotted, thanks for filing. The bug is in the code not the readme because the options are supposed to be prefixed.

On 17 Mar 2015, at 13:39, Ross Johnson notifications@github.com wrote:

The readme file lists PDF options with a pdf prefix, however; the fillPdfOptions() method looks for options without the prefix. I would be happy to make a PR, I just need to know if you want to update the README or the option parser.

Thanks!

—
Reply to this email directly or view it on GitHub.

@rossj rossj mentioned this issue Mar 17, 2015
Merged
@mattcg mattcg closed this as completed Mar 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattcg @rossj