Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display 'intro' Snippets automatically after parsing the job description. #1

Closed
mattcheah opened this issue Jul 31, 2018 · 9 comments
Closed
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mattcheah
Copy link
Owner

Currently, no snippets in the database are shown after parsing the job description, and the user must click on "Show Snippets" for a specific category to show any cover letter snippets in the database.

Since most users would always start off with an introduction, the first category of snippets to show from the database should be the "intro" snippets. It should show immediately after parsing the job description, not just after the "Show Snippets" button is clicked.

The logic for this is located in the ResultsComponent and retrieves records form the DatabaseService.database object.
A callback can be initiated after the ParseDescriptionService is finished, which runs the function displaySnippets('intro') in ResultsComponent, or it can be done some other way.

I'd be happy to help out with anyone who wants to take this on.

@mattcheah mattcheah added help wanted Extra attention is needed good first issue Good for newcomers labels Jul 31, 2018
@Brechy
Copy link

Brechy commented Oct 5, 2018

I would like to work on this enhancement if that's OK. Thanks!

@mattcheah
Copy link
Owner Author

@Brechy Please do, thanks!

@mattcheah
Copy link
Owner Author

hi @Brechy, how are you doing on this?

@Brechy
Copy link

Brechy commented Oct 16, 2018 via email

@bhshkh
Copy link

bhshkh commented Jan 26, 2019

@mattcheah Is this up for grabs?

@mattcheah
Copy link
Owner Author

@bhshkh yeah go ahead! Doesn't look like it's being worked on right now. Please let me know if you need help or would like any advice on where to start learning about how the structure of the app works. Good luck!

@ChellappanRajan
Copy link

Hi @mattcheah , is it still open ? If it still open can i take this?

@mattcheah
Copy link
Owner Author

@ChellappanRajan go ahead! It’s been about a year since I’ve worked on this so let me know if everything is working alright for you.

@ChellappanRajan
Copy link

I am able to run locally and made those changes, do i need any permission to raise PR?

vibharaj added a commit to vibharaj/cover-letter-snippets that referenced this issue Jun 7, 2021
…omatically visible after parsing the job description and the job description can be displayed if the user clicks on the description panel as an accordian
mattcheah added a commit that referenced this issue Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants