Bundle if browserify entries specified #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks! |
mattdesl
added a commit
that referenced
this pull request
Jan 28, 2017
Bundle if browserify entries specified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for bundling even when no entries are passed to budo directly.
This is useful when specifying stream entries (via the
entriesfield in the browserify opts), which budo won't accept but browserify will.I'm not quire sure how the
ev.entriesin theconnectcallback should be handled in this case, since it could be a stream (rather than file), but for now, simply using an empty array seemed ok.This seemed cleaner than having some
--always-bundleboolean flag, but it's sort of implicit. I'm happy to make whatever changes are needed. Basically I just want to use budo programmatically with a generated entry file that is not actually written to the file system.