Add Unit Tests #110
Open
Add Unit Tests #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had some time so I added a few more tests. Also, It looks like the Netlify pipeline isn't passing because it's still on Node 8, but Jest 26/27 require Node 10 or above. I would downgrade to Jest 24, but it doesn't play as nicely with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Matt!
I noticed in your readme you want to add unit tests - I've set up Jest for
canvas-sketchand added a few basic tests just to get the ball rolling. I'm happy to add more but wanted to submit a PR early in case you have any feedback.jestbabelto handle ES6 import syntaxcreateCanvasandSketchManager