Improved library API and added automatic HttpClient disposal #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added Brotli automatic decompression and added a new HttpRequest field called HttpVersion to set the HTTP protocol version.
to avoid confusion between this field and the Content-Type HTTP header.
|
Hey, you probably don't even remember this. Sorry for the delay. I'm going to release v1.3.0 with some of these changes: https://github.com/matteocontrini/PlainHttp/releases/tag/v1.3.0 These are the non-breaking ones which I'm comfortable with releasing right now. The other changes need a bit more thought IMO, or they are breaking changes that require a 2.0 to be tagged in order to follow semantic versioning. I'm going to close this for now but thanks for your helpful contributions! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the first three of the features suggested here: #4
HttpVersionfield toHttpRequestclass to allow changing the HTTP protocol version.ContentTypefield inHttpRequesttoPayloadSerializationTypeto avoid confusion between ``Content-Type` header.System.Text.Jsoninstead.HttpClientFactory.Proxyfield's type inHttpRequesttoIWebProxyto allow user-defined classes to be used.