Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes phpcollection/phpcollection redundant #189

Merged
merged 6 commits into from Nov 20, 2022

Conversation

jurgenhaas
Copy link
Contributor

Fixes #188

@GenieTim
Copy link
Collaborator

GenieTim commented Nov 17, 2022

Thank you very much for this contribution!
If you want, you can use composer fix-cs to automatically fix the code style issues

@jurgenhaas
Copy link
Contributor Author

Hmm, that was kind of a challenge. I cloned the repository, ran composer update and then called composer fix-cs which failed with error messages like this:

Call to undefined function grapheme_strlen() in /drupal/vendor/symplify/easy-coding-standard/vendor/symfony/string/UnicodeString.php:171

Not sure, why that happened but I replaced grapheme_strlen with mb_strlen and then the tests worked.

I then realized that the code quality of those classes was really terribly. I went through a couple of iterations and then just had some errors left from classes, that had been there before:

Property GitElephant\Objects\Diff\DiffChunk::$originStartLine (int) does not accept string.

I fixed them as well, hoping this is not breaking anything. But now it seems that the testbot is running into timeouts. Can you probably force a re-test?

@GenieTim GenieTim merged commit adee7d9 into matteosister:develop Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

phpcollection/phpcollection seems to be unmaintained
2 participants