feat: new automation scope for tests on Contracts API + Tokens API #170

olehbairak · 2024-02-14T15:13:03Z

What ❔

Implemented automation test coverage for next test cases:
https://linear.app/matterlabs/issue/QA-653/%5Btokensapi-contracts-api%5D-automate-test-cases-for-contracts-api-for-be

Why ❔

To check this functionality in PR automation integration tests.

Checklist

PR title corresponds to the body of PR (we generate changelog entries from PRs).
Tests for the changes have been added / updated.
Documentation comments have been added / updated.

github-actions · 2024-02-14T15:14:38Z

API E2E Test Results

206 tests 206 ✅ 20s ⏱️
14 suites 0 💤
1 files 0 ❌

Results for commit 98f183d.

♻️ This comment has been updated with latest results.

github-actions · 2024-02-14T15:18:03Z

Visit the preview URL for this PR (updated for commit 98f183d):

_{(expires Fri, 12 Apr 2024 12:19:36 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: e508f9012944951194447cb8885950b451a24403}

github-actions · 2024-02-14T15:18:48Z

Unit Test Results

4 files 263 suites 11m 55s ⏱️
2 079 tests 2 078 ✅ 1 💤 0 ❌
2 284 runs 2 283 ✅ 1 💤 0 ❌

Results for commit 98f183d.

♻️ This comment has been updated with latest results.

packages/integration-tests/src/helper.ts

packages/integration-tests/tests/api/contracts.test.ts

olehbairak · 2024-02-16T15:34:54Z

@pcheremu can you please review the PR?
Thank you in advance.

packages/integration-tests/tests/api/tokens.test.ts

packages/integration-tests/src/helper.ts

packages/integration-tests/tests/api/contracts.test.ts

pcheremu

@olehbairak please, apply changes based on comments

olehbairak · 2024-02-27T10:36:55Z

@olehbairak please, apply changes based on comments

@pcheremu thank you for the feedback!
Already fixed!

pcheremu

@abilevych all essential changes were applied. I'm still thinking about helper.performGETrequest(apiRoute). From the one hand we can have an agreement that if we use just one variable it will mean that the network will be local, from the other hand, as for me, it will be more clear to have two arguments helper.performGETrequest(apiRoute, network) to transfer there more explicitly. Both options are make sense, please let us know what would you prefer in this case?

packages/integration-tests/src/helper.ts

abilevych · 2024-03-04T13:25:00Z

packages/integration-tests/src/helper.ts

@@ -61,8 +61,14 @@ export class Helper {
    return new Promise((resolve) => setTimeout(resolve, ms));
  }

-  async performGETrequest(apiRoute: string) {
-    return request(environment.blockExplorerAPI).get(apiRoute);
+  async performGETrequest(apiRoute: string, network = "local") {


Also, I assume the name "environment" is a better option for a parameter than the "network" is.

environment name is already used in config.ts

abilevych · 2024-03-04T13:26:16Z

packages/integration-tests/tests/api/contracts.test.ts

@@ -22,6 +22,59 @@ describe("API module: Contract", () => {
      await playbook.deployMultiCallContracts();
    });

+    //id1851


I'd mark here by tag\comment that tests or suite related to the Sepolia network (or environment)

abilevych · 2024-03-04T13:27:06Z

packages/integration-tests/tests/api/contracts.test.ts

+      await helper.retryTestAction(async () => {
+        apiRoute = `/api?module=contract&action=checkverifystatus&guid=3177`;
+        response = await helper.performGETrequest(apiRoute, "sepolia");
+        console.log(response.body);


Is that necessary to have it here?

packages/integration-tests/tests/api/tokens.test.ts

olehbairak · 2024-03-05T11:31:02Z

@pcheremu @abilevych I fixed comments.
Can you please review the changes?
Thank you in advance!

…sapi-accounts-api-automate-test-cases-for-contracts-api

…53-tokensapi-accounts-api-automate-test-cases-for-contracts-api" This reverts commit e2445ba, reversing changes made to f628183.

…rak-qa-653-tokensapi-accounts-api-automate-test-cases-for-contracts-api"" This reverts commit 7fa1b56.

…sapi-accounts-api-automate-test-cases-for-contracts-api

olehbairak · 2024-03-20T12:42:45Z

@abilevych conflicts were resolved.
Now branch is up to date and ready for review.

packages/integration-tests/src/helper.ts

abilevych · 2024-04-05T12:13:43Z

@abilevych all essential changes were applied. I'm still thinking about helper.performGETrequest(apiRoute). From the one hand we can have an agreement that if we use just one variable it will mean that the network will be local, from the other hand, as for me, it will be more clear to have two arguments helper.performGETrequest(apiRoute, network) to transfer there more explicitly. Both options are make sense, please let us know what would you prefer in this case?

abilevych · 2024-04-05T12:17:46Z

@olehbairak I messed up a bit with git (closed the PR by mistake). please re-start all those checks if it's needed and once it's done you can merge it by yourself.

Sorry for some inconvenience

olehbairak · 2024-04-08T07:30:39Z

@olehbairak please, apply changes based on comments

@pcheremu can you please resolve the request change - it's currently blocking from merge.
Seems like all the requested changes were made and the PR can be merged.
Thank you in advance!

fix: new one

8523fac

olehbairak added the automation writing/fixing/maintaining auto-tests/e2e-tests label Feb 14, 2024

olehbairak self-assigned this Feb 14, 2024

olehbairak changed the title ~~fix: new one~~ feat: new automation scope for tests on Contracact API + Tokens API Feb 14, 2024

olehbairak added 4 commits February 14, 2024 16:31

fix: new one

f5d3549

fix: new one

ad02485

fix: new one

c549d97

fix: remove un contract playbook

e3aa291

olehbairak commented Feb 16, 2024

View reviewed changes

packages/integration-tests/src/helper.ts Outdated Show resolved Hide resolved

olehbairak commented Feb 16, 2024

View reviewed changes

packages/integration-tests/tests/api/contracts.test.ts Outdated Show resolved Hide resolved

olehbairak requested review from pcheremu and abilevych February 16, 2024 15:34

olehbairak marked this pull request as ready for review February 16, 2024 15:34

pcheremu reviewed Feb 16, 2024

View reviewed changes

packages/integration-tests/tests/api/tokens.test.ts Outdated Show resolved Hide resolved

packages/integration-tests/src/helper.ts Outdated Show resolved Hide resolved

olehbairak requested a review from pcheremu February 19, 2024 10:28

olehbairak changed the base branch from integration-tests to integration-tests-signed February 21, 2024 15:24

pcheremu reviewed Feb 27, 2024

View reviewed changes

packages/integration-tests/src/helper.ts Show resolved Hide resolved

pcheremu reviewed Feb 27, 2024

View reviewed changes

packages/integration-tests/tests/api/contracts.test.ts Outdated Show resolved Hide resolved

pcheremu requested changes Feb 27, 2024

View reviewed changes

fix: review feedback

4735b11

olehbairak requested a review from pcheremu February 27, 2024 10:36

fix: new one

dd2c1b8

pcheremu reviewed Feb 27, 2024

View reviewed changes

abilevych requested changes Mar 4, 2024

View reviewed changes

fix: new one

c5a86cf

olehbairak requested review from pcheremu and abilevych March 5, 2024 11:30

Merge branch 'integration-tests-signed' into oleh-bairak-qa-653-token…

e2445ba

…sapi-accounts-api-automate-test-cases-for-contracts-api

olehbairak requested review from abilevych and pcheremu and removed request for pcheremu and abilevych March 7, 2024 10:15

olehbairak and others added 6 commits March 7, 2024 11:42

Revert "Merge branch 'integration-tests-signed' into oleh-bairak-qa-6…

7fa1b56

…53-tokensapi-accounts-api-automate-test-cases-for-contracts-api" This reverts commit e2445ba, reversing changes made to f628183.

Revert "Revert "Merge branch 'integration-tests-signed' into oleh-bai…

78a146c

…rak-qa-653-tokensapi-accounts-api-automate-test-cases-for-contracts-api"" This reverts commit 7fa1b56.

Merge branch 'integration-tests-signed' into oleh-bairak-qa-653-token…

9ff2fd0

…sapi-accounts-api-automate-test-cases-for-contracts-api

fix: new version

ac55ca4

fix: lint error fix

4c350d0

Merge branch 'integration-tests-signed' into oleh-bairak-qa-653-token…

0fa8b72

…sapi-accounts-api-automate-test-cases-for-contracts-api

olehbairak changed the title ~~feat: new automation scope for tests on Contracact API + Tokens API~~ feat: new automation scope for tests on Contracts API + Tokens API Mar 11, 2024

olehbairak and others added 3 commits March 12, 2024 11:03

Update helper.ts

bd1e328

fix: new one after rebase

834384b

Merge branch 'integration-tests-signed' into oleh-bairak-qa-653-token…

1c6e8ce

…sapi-accounts-api-automate-test-cases-for-contracts-api

abilevych requested changes Mar 29, 2024

View reviewed changes

packages/integration-tests/src/helper.ts Outdated Show resolved Hide resolved

olehbairak added 2 commits March 29, 2024 14:58

fix: new one

21fbfb5

fix: new one

98f183d

abilevych closed this Apr 5, 2024

abilevych reopened this Apr 5, 2024

abilevych approved these changes Apr 5, 2024

View reviewed changes

olehbairak merged commit 26cf37a into integration-tests-signed Apr 8, 2024
68 of 69 checks passed

olehbairak deleted the oleh-bairak-qa-653-tokensapi-accounts-api-automate-test-cases-for-contracts-api branch April 8, 2024 07:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: new automation scope for tests on Contracts API + Tokens API #170

feat: new automation scope for tests on Contracts API + Tokens API #170

olehbairak commented Feb 14, 2024 •

edited

Loading

github-actions bot commented Feb 14, 2024 •

edited

Loading

github-actions bot commented Feb 14, 2024 •

edited

Loading

github-actions bot commented Feb 14, 2024 •

edited

Loading

olehbairak commented Feb 16, 2024

pcheremu left a comment

olehbairak commented Feb 27, 2024

pcheremu left a comment •

edited

Loading

abilevych Mar 4, 2024

olehbairak Mar 4, 2024

olehbairak Mar 12, 2024

abilevych Mar 4, 2024

olehbairak Mar 4, 2024

abilevych Mar 4, 2024

olehbairak Mar 4, 2024

olehbairak commented Mar 5, 2024

olehbairak commented Mar 20, 2024

abilevych commented Apr 5, 2024

abilevych commented Apr 5, 2024

olehbairak commented Apr 8, 2024

feat: new automation scope for tests on Contracts API + Tokens API #170

feat: new automation scope for tests on Contracts API + Tokens API #170

Conversation

olehbairak commented Feb 14, 2024 • edited Loading

What ❔

Why ❔

Checklist

github-actions bot commented Feb 14, 2024 • edited Loading

API E2E Test Results

github-actions bot commented Feb 14, 2024 • edited Loading

github-actions bot commented Feb 14, 2024 • edited Loading

Unit Test Results

olehbairak commented Feb 16, 2024

pcheremu left a comment

Choose a reason for hiding this comment

olehbairak commented Feb 27, 2024

pcheremu left a comment • edited Loading

Choose a reason for hiding this comment

abilevych Mar 4, 2024

Choose a reason for hiding this comment

olehbairak Mar 4, 2024

Choose a reason for hiding this comment

olehbairak Mar 12, 2024

Choose a reason for hiding this comment

abilevych Mar 4, 2024

Choose a reason for hiding this comment

olehbairak Mar 4, 2024

Choose a reason for hiding this comment

abilevych Mar 4, 2024

Choose a reason for hiding this comment

olehbairak Mar 4, 2024

Choose a reason for hiding this comment

olehbairak commented Mar 5, 2024

olehbairak commented Mar 20, 2024

abilevych commented Apr 5, 2024

abilevych commented Apr 5, 2024

olehbairak commented Apr 8, 2024

olehbairak commented Feb 14, 2024 •

edited

Loading

github-actions bot commented Feb 14, 2024 •

edited

Loading

github-actions bot commented Feb 14, 2024 •

edited

Loading

github-actions bot commented Feb 14, 2024 •

edited

Loading

pcheremu left a comment •

edited

Loading