Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: create autotests for Withdraw test cases #190

Merged

Conversation

amelnytskyi
Copy link
Contributor

@amelnytskyi amelnytskyi commented Feb 27, 2024

What ❔

  • Added autotests for Withdraw and Account test cases
    1686 [Withdrawal] Check on BE Verify the ETH withdrawal to the other address via /transactions/{transactionHash}/transfers
    1685 [Transactions] Check on BE Withdraw the custom ERC-20 via Portal (zkSync SDK)
    1664 [Transactions] Check Withdraw transaction on BE for custom ERC-20 token (USDC) to a different address token via Portal (zkSync SDK)
    1661 [Transactions] Check Withdraw ETH transaction on BE (zkSync SDK)

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

@amelnytskyi amelnytskyi added the automation writing/fixing/maintaining auto-tests/e2e-tests label Feb 27, 2024
@amelnytskyi amelnytskyi self-assigned this Feb 27, 2024
Copy link

github-actions bot commented Feb 27, 2024

API E2E Test Results

206 tests   - 1   206 ✅  - 1   27s ⏱️ -1s
 14 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 745ce83. ± Comparison against base commit 1688bf6.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 27, 2024

Unit Test Results

    4 files  ±0    263 suites  ±0   13m 44s ⏱️ +14s
2 079 tests  - 3  2 078 ✅  - 3  1 💤 ±0  0 ❌ ±0 
2 284 runs   - 6  2 283 ✅  - 6  1 💤 ±0  0 ❌ ±0 

Results for commit 745ce83. ± Comparison against base commit 1688bf6.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 27, 2024

Visit the preview URL for this PR (updated for commit 745ce83):

(expires Wed, 20 Mar 2024 12:14:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e508f9012944951194447cb8885950b451a24403

@amelnytskyi amelnytskyi changed the title test: create autotests for Withdraw and Account test cases test: create autotests for Withdraw test cases Feb 27, 2024
Copy link
Collaborator

@pcheremu pcheremu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably the PR can be optimized by comments above.

@pcheremu pcheremu requested a review from abilevych March 5, 2024 12:29
@amelnytskyi amelnytskyi force-pushed the QA-688-Withdrawal-BE-API-test-cases branch from 17ea962 to a6bf6af Compare March 12, 2024 14:27
@amelnytskyi
Copy link
Contributor Author

@abilevych conflicts resolved after rebase and fixes - ready for review again

Fixed explicit timeout and changed const txSumETH to enum data type
@amelnytskyi
Copy link
Contributor Author

@abilevych all requested changes added - could you please review?

@amelnytskyi amelnytskyi merged commit f4442b2 into integration-tests-signed Mar 20, 2024
36 checks passed
@amelnytskyi amelnytskyi deleted the QA-688-Withdrawal-BE-API-test-cases branch March 20, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation writing/fixing/maintaining auto-tests/e2e-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants