Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: new formatting and screenshots addition #231

Conversation

olehbairak
Copy link
Collaborator

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

amelnytskyi and others added 30 commits February 6, 2024 19:31
Adding initial scope of Docusaurus project for testing docs
# What ❔

fix npm issues 

## Why ❔

Conflict in react packages: To resolve build with latest deps first. 

## Checklist


- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
# What ❔

Removing extra symbols that prevents page from loading.
After the test cases were imported from Allure project - some of the
pages didn't load because of the different symbols.

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
# What ❔

- Removed obsolete Blogs and Tutorials docs
- fixing folders structure for BE docs (docusaurus project)
- cleaned index page 

## Why ❔


## Checklist


- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.

---------

Co-authored-by: pcheremu <pavel.cheremushkin@gmail.com>
@olehbairak olehbairak self-assigned this Apr 15, 2024
@olehbairak olehbairak changed the base branch from main to QA-613-add-docusaurus-docs-project April 15, 2024 14:27
@olehbairak olehbairak added the documentation Improvements or additions to documentation label Apr 15, 2024
@olehbairak olehbairak marked this pull request as ready for review April 15, 2024 15:34
@@ -0,0 +1,17 @@
---
tags: ['Full test', 'manual', 'Navigation', 'Network', 'regression', 'To Automate', 'ZKF-2507', 'Active']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olehbairak Do we decide to remove all ZKF-**** tags?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, fixed.
Thank you!

@@ -0,0 +1,17 @@
---
tags: ['Full test', 'manual', 'Navigation', 'Network', 'Smoke test', 'ZKF-2507', 'Automated']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, can you please sort/select/take attention is the test case 'manual' or 'automated'? We have to keep only one of this tags.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, fixed.
Thank you!


## Scenario
- Prepare a custom token on L2
- Make a request to show the balance
- ?module=account&action=tokenlist&address=\{hash\}
- You can see the token with its balance
- ![Screenshot](../../../../static/img/screenshots/common/BlockscoutAPI/id546_1.png);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pcheremu
Copy link
Collaborator

@olehbairak Please create a task to clean extra ZKF tags and check if test case contains only one (manual or automated tag). feel free to merge this PR to the initial and create another one based on linear task or make this fix in the same PR. @amelnytskyi fyi

Copy link
Collaborator

@pcheremu pcheremu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Later lets decide, do we want to have Automated and partly manual together. F.e. test id212
tags: ['Artifacts', 'Automated', 'Full test', 'Single-file', 'Smart Contract Verification page', 'Smoke test', 'Solidity', 'Active Partly Manual']

@olehbairak
Copy link
Collaborator Author

Later lets decide, do we want to have Automated and partly manual together. F.e. test id212 tags: ['Artifacts', 'Automated', 'Full test', 'Single-file', 'Smart Contract Verification page', 'Smoke test', 'Solidity', 'Active Partly Manual']

Yes, totally agree. We need to define whether these is the same, cause in fact they are partly automated, or to have only one identifier.

@amelnytskyi
Copy link
Contributor

Later lets decide, do we want to have Automated and partly manual together. F.e. test id212 tags: ['Artifacts', 'Automated', 'Full test', 'Single-file', 'Smart Contract Verification page', 'Smoke test', 'Solidity', 'Active Partly Manual']

Let's have only 'Active Partly Manual' for such cases - WDYT?

@pcheremu
Copy link
Collaborator

Yep, Lets keep only one tag the will describe the status. And be careful with signing that we unexpectedly see here.

Copy link
Collaborator

@pcheremu pcheremu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All commits should be signed

@pcheremu pcheremu changed the base branch from QA-613-add-docusaurus-docs-project to main April 16, 2024 11:06
@pcheremu pcheremu changed the base branch from main to QA-613-add-docusaurus-docs-project April 16, 2024 11:06
@olehbairak olehbairak closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants