Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MC] Emit warnings for non-standard and deprecated instructions #577

Open
atrosinenko opened this issue May 28, 2024 · 1 comment
Open

[MC] Emit warnings for non-standard and deprecated instructions #577

atrosinenko opened this issue May 28, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@atrosinenko
Copy link
Collaborator

atrosinenko commented May 28, 2024 •
edited
Loading

It was discussed in #483 and #567 that warnings/errors should be printed by default when trying to print/emit a non-canonical form of nop (that is, not aliasing to either incsp, decsp or no-operand nop) or retl/revl with register operand being not the default R1.

As discussed in #444, warning should be shown for stpub instruction (previously context.set_gas_per_pubdata) that was removed from VM 1.5.0.
This was referenced May 28, 2024
Open
Closed
@asl asl added the enhancement New feature or request label May 30, 2024
@atrosinenko atrosinenko changed the title [MC] Emit warnings for non-canonical nop, retl, revl instruction forms [MC] Emit warnings for non-standard and deprecated instructions May 30, 2024
@atrosinenko
Copy link
Collaborator Author

Updated the description to show warning for stpub as well.

@atrosinenko atrosinenko mentioned this issue May 30, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asl @atrosinenko