Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the build script to MUSL #85

Merged
merged 10 commits into from
Jul 14, 2022
Merged

Change the build script to MUSL #85

merged 10 commits into from
Jul 14, 2022

Conversation

hedgar2017
Copy link
Collaborator

No description provided.

@hedgar2017 hedgar2017 marked this pull request as ready for review July 13, 2022 13:27
@hedgar2017 hedgar2017 changed the title Add the MUSL build script Change the build script to MUSL Jul 13, 2022
@zksync-admin-bot2
Copy link
Collaborator

Benchmark results:

╔═══════════════╡ Size (-%) ╞═══════════════╗
║ Mean                               -0.000 ║
║ Best                                0.000 ║
║ Worst                              -0.787 ║
║ Total                              -0.001 ║
╠══════════════╡ Cycles (-%) ╞══════════════╣
║ Mean                               -0.000 ║
║ Best                                0.290 ║
║ Worst                              -0.424 ║
║ Total                              -0.000 ║
╚═══════════════════════════════════════════╝

akiramenai
akiramenai approved these changes Jul 14, 2022
View reviewed changes
Copy link
Collaborator

@akiramenai akiramenai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash into one commit before merging

@hedgar2017 hedgar2017 merged commit 8b5e5ec into dev-1.1 Jul 14, 2022
@hedgar2017 hedgar2017 deleted the musl-ci branch July 14, 2022 15:47
akiramenai pushed a commit that referenced this pull request Dec 1, 2022
@hedgar2017 @akiramenai
[CI] Change the build script to MUSL (#85)
73e9898 
* Add the MUSL build script

* Install ninja

* Install the Rust target for MUSL

* Install musl-gcc

* Fix the LLVM output path

* Fix the LLVM unit test path and target

* Re-enable unit tests building

* Remove the unit tests CI step

Co-authored-by: Alex Z <a.zarudnyy@matterlabs.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akiramenai akiramenai akiramenai approved these changes

@hatemosphere hatemosphere Awaiting requested review from hatemosphere

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hedgar2017 @zksync-admin-bot2 @akiramenai