Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(contracts): removed todo comments #181

Merged
merged 1 commit into from Feb 2, 2024
Merged

chore(contracts): removed todo comments #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion l1-contracts/contracts/zksync/facets/Executor.sol
View file
Open in desktop
Expand Up @@ -41,7 +41,6 @@ contract ExecutorFacet is Base, IExecutor {
// Get the chained hash of priority transaction hashes.
LogProcessingOutput memory logOutput = _processL2Logs(_newBatch, _expectedSystemContractUpgradeTxHash);

// TODO: Adapt to handle dynamic number of blobs
bytes32[] memory blobCommitments = new bytes32[](MAX_NUMBER_OF_BLOBS);
bytes32[] memory blobHashes = new bytes32[](MAX_NUMBER_OF_BLOBS);
if (pubdataSource == uint8(PubdataSource.Blob)) {
Expand Down
2 changes: 1 addition & 1 deletion system-contracts/contracts/PubdataChunkPublisher.sol
View file
Open in desktop
Expand Up @@ -20,7 +20,7 @@ contract PubdataChunkPublisher is IPubdataChunkPublisher, ISystemContract {
/// @dev We always publish 2 system logs even if our pubdata fits into a single blob. This makes processing logs on L1 easier.
function chunkAndPublishPubdata(bytes calldata _pubdata) external onlyCallFrom(address(L1_MESSENGER_CONTRACT)) {
require(_pubdata.length <= BLOB_SIZE_BYTES * MAX_NUMBER_OF_BLOBS, "pubdata should fit in 2 blobs");
// TODO: Update for dynamic number of blobs

bytes32[] memory blobHashes = new bytes32[](MAX_NUMBER_OF_BLOBS);

// We allocate to the full size of MAX_NUMBER_OF_BLOBS * BLOB_SIZE_BYTES because we need to pad
Expand Down