feat(validator): modified validator timelock to allow more than 1 validator #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koloz193
requested review from
vladbochok and
StanislavBreadless
as code owners
StanislavBreadless
approved these changes
Feb 21, 2024
|
|
||
| /// @dev Sets an address as a validator. | ||
| function addValidator(address _newValidator) external onlyOwner { | ||
| validators[_newValidator] = true; |
There was a problem hiding this comment.
nit: it may be worth to double check whether the validator has not been set already (in case of adding a new validator) / has not been removed already (in case of deletion)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Modified validator timelock to allow more than 1 validator
Why ❔
For 4844 we want to be able to use 2 different addresses:
The separation is mainly due to the fact that normal and blob transactions have separate mem pools and restrictions on when an address can have a transaction in each of the respective pools
Checklist