feat(executor): add blob linear hash and commitment to calldata #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koloz193
requested review from
vladbochok and
StanislavBreadless
as code owners
perekopskiy
reviewed
Feb 23, 2024
perekopskiy
approved these changes
Feb 23, 2024
StanislavBreadless
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
We append an extra 64 bytes to the end of the pubdata sent when using calldata. This data represents the linear hash and commitment for a single blob.
Why ❔
By sending these values and having them be part of the batch commitment we can take an easier approach for generating witnesses and proofs.
Checklist