Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean imports #265

Merged
merged 13 commits into from
Mar 13, 2024
Merged

Clean imports #265

merged 13 commits into from
Mar 13, 2024

Conversation

dnkolegov
Copy link
Collaborator

@dnkolegov dnkolegov commented Mar 12, 2024 •
edited
Loading

What ❔

This PR does the following:

  • it removes unused imports and specifies concrete types instead of global imports
  • it changes the solhint policy to detect these two inconsistencies in the code

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

@dnkolegov dnkolegov requested a review from saxenism March 12, 2024 22:13
@dnkolegov dnkolegov marked this pull request as ready for review March 12, 2024 22:23
@StanislavBreadless
Copy link
Collaborator

@dnkolegov Would it be possible to create a CI for this process?

StanislavBreadless
StanislavBreadless approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@StanislavBreadless StanislavBreadless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good, but it would be even better if we could have a CI that could check for unused imports

@dnkolegov
Copy link
Collaborator Author

@dnkolegov Would it be possible to create a CI for this process?

Yes, it is possible. We need to add those checks to the solhint policy. Will do.

@dnkolegov dnkolegov merged commit c88b76c into dev Mar 13, 2024
17 checks passed
@dnkolegov dnkolegov deleted the denis/dev_solhint_cleaning branch March 13, 2024 14:59
@vladbochok
Copy link
Member

@dnkolegov After the merge please fix merge conflicts in #251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladbochok vladbochok vladbochok approved these changes

@saxenism saxenism Awaiting requested review from saxenism

@StanislavBreadless StanislavBreadless Awaiting requested review from StanislavBreadless StanislavBreadless is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dnkolegov @StanislavBreadless @vladbochok