Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Evm equivalence in yul #364

Draft
wants to merge 641 commits into
base: dev
Choose a base branch
from
Draft

feat: Evm equivalence in yul #364

wants to merge 641 commits into from

Conversation

jrchatruc
Copy link
Contributor

What ❔

This PR adds an EVM Yul Interpreter on top of the already existing Solidity EVM Interpreter effort

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

@jrchatruc jrchatruc changed the base branch from main to dev April 15, 2024 14:28
@jrchatruc jrchatruc changed the base branch from dev to sb-1-5-0-evm-eq-integration April 16, 2024 15:50
fborello-lambda and others added 28 commits April 29, 2024 12:33
@fborello-lambda @jrchatruc
refactor(dup opcode): move chargeGas() location
c08dd83
@fborello-lambda @jrchatruc
fix(dup-opcode): Replace + with add()
8d1a543
@fborello-lambda @jrchatruc
feat(dup-opcode): Implement tested opcode
01b3afd
@fborello-lambda @jrchatruc
feat(swap-opcode): Add swap opcodes
55d971a
@ManuelBilbao @jrchatruc
Add div opcode
f03fd7a
@ManuelBilbao @jrchatruc
Add sdiv opcode
ec94ad8
@ManuelBilbao @jrchatruc
Add mod opcode
07216ad
@ManuelBilbao @jrchatruc
Add smod opcode
cdfebaa
@ManuelBilbao @jrchatruc
Optimize readBytes function used by pushN opcodes
041c1b9 
With this change, the function will stop doing N (from pushN) `add`s,
but only one, whatever N be.
@ManuelBilbao @jrchatruc
Add lt opcode
4db5bd8
@ManuelBilbao @jrchatruc
Add gt opcode
f3d8637
@ManuelBilbao @jrchatruc
Add slt opcode
e167aad
@ManuelBilbao @jrchatruc
Add sgt opcode
6345736
@ManuelBilbao @jrchatruc
Add eq opcode
ba67af7
@ManuelBilbao @jrchatruc
Add iszero opcode
8f7f505
@ManuelBilbao @jrchatruc
Add xor opcode
920a5a5
@ManuelBilbao @jrchatruc
Add not opcode
f1f5ec7
@ManuelBilbao @jrchatruc
Add byte opcode
88a1883
@jrchatruc
Add basic "print" functions
1b7c742
@jrchatruc
Better print functionality
6bd9dda
@jrchatruc
Make prints not clobber each other when called in succesion
1a98547
@ManuelBilbao
Refactor extcodecopy opcode
6b50152
@ManuelBilbao @jrchatruc
Add jump and jumpdest opcodes
e8727dc
@ManuelBilbao @jrchatruc
Add jumpi opcode
fef63ae
@ManuelBilbao @jrchatruc
Charge gas on jumps
b6dbd01
@ManuelBilbao @jrchatruc
Fix sintaxis error
e4cba07
@ManuelBilbao @jrchatruc
Add gas charge on pushn opcodes
816078a
@ManuelBilbao @jrchatruc
Add gas charge to remaining opcodes
7430e79
gianbelinche and others added 30 commits May 27, 2024 11:15
@gianbelinche
Remove memCost function
f1817ef
@gianbelinche
Revert "Remove memCost function"
63d1f43 
This reverts commit f1817ef.
@gianbelinche
Remove memcost
a702849
@jrchatruc
Merge pull request #488 from lambdaclass/optimizations
a2b77bd 
[EVM-Equivalence-YUL] Opcode Optimizations
@gianbelinche
Fix extcodecopy not storing on dest
ff2fe0f
@gianbelinche
Fix extcodecopy reverting con empty address
c9d9883
@jrchatruc
Merge pull request #515 from lambdaclass/extcodecopy-fix
45d2c6d 
[EVM-Equivalence-YUL] Extcodecopy fix
@gianbelinche
Add check for overflow
2e190af
@gianbelinche
Fix keccak
a043c2b
@gianbelinche
Fix returndatacopy checks
f44956b
@gianbelinche
fix mload
7da9bc4
@gianbelinche
Fix return overflow checks
ea6ce17
@gianbelinche
Fix compilation
5879008
@gianbelinche
Add mcopy
f595f66
@jrchatruc
Changes to fix tests
ecc51e2
@jrchatruc
Fix off by one errors in msize
6b3da03
@jrchatruc
Add tload and tstore
559ee47
@jrchatruc
Fix create checking balance incorrectly, revert tstore on static calls
126c052
@jrchatruc
Return gas on push stack reverts
f9b5bd0
@jrchatruc
Fix balance not truncating addresses to the first 20 bytes
34296da
@jrchatruc
Truncate addresses to first 20 bytes in extcodehash
0828191
@jrchatruc
Truncate addresses on delegatecall
fa8338b
@jrchatruc
Fix extcodesize
78b698b
@jrchatruc
Pass stipend on EVM calls as the zkevm gas
26e3ea9
@IAvecilla
Copy zeroes in memory overflow for calldatacopy
34ee366
@gianbelinche
Fix create unnecessary revert
3a09b39
@IAvecilla
Revert with gas for pop stack operation
61c0568
@IAvecilla
Update preprocessed file
420d9ea
@IAvecilla
Handle test case of address 0 in extcodehash to match with solidity
de9afeb
@jrchatruc
Merge pull request #527 from lambdaclass/fix-compiler-tester-bugs
e730132 
[EVM-Equivalence-YUL] Fix compiler tester bugs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladbochok vladbochok Awaiting requested review from vladbochok vladbochok will be requested when the pull request is marked ready for review vladbochok is a code owner

@StanislavBreadless StanislavBreadless Awaiting requested review from StanislavBreadless StanislavBreadless will be requested when the pull request is marked ready for review StanislavBreadless is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jrchatruc @fborello-lambda @ManuelBilbao @gianbelinche @fkrause98 @IAvecilla