Packed protocol version #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perekopskiy
reviewed
May 24, 2024
l1-contracts/contracts/state-transition/chain-interfaces/IGetters.sol
Outdated
Show resolved
Hide resolved
vladbochok
reviewed
May 24, 2024
vladbochok
reviewed
May 24, 2024
vladbochok
reviewed
May 24, 2024
vladbochok
reviewed
May 24, 2024
vladbochok
reviewed
May 24, 2024
vladbochok
reviewed
May 24, 2024
There was a problem hiding this comment.
@StanislavBreadless We firstly need to bump protocol version and then start using this contract, right?
Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com>
Use `CONTRACTS_GENESIS_PROTOCOL_SEMANTIC_VERSION` variable
… sb-packed-protocol-version
perekopskiy
reviewed
May 24, 2024
Co-authored-by: perekopskiy <53865202+perekopskiy@users.noreply.github.com>
perekopskiy
approved these changes
May 24, 2024
vladbochok
reviewed
May 24, 2024
Raid5594
pushed a commit
that referenced
this pull request
May 30, 2024
Co-authored-by: perekopskiy <mikeson.dp@gmail.com> Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com> Co-authored-by: perekopskiy <53865202+perekopskiy@users.noreply.github.com>
Raid5594
pushed a commit
that referenced
this pull request
May 30, 2024
Co-authored-by: perekopskiy <mikeson.dp@gmail.com> Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com> Co-authored-by: perekopskiy <53865202+perekopskiy@users.noreply.github.com>
Raid5594
pushed a commit
that referenced
this pull request
May 30, 2024
Co-authored-by: perekopskiy <mikeson.dp@gmail.com> Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com> Co-authored-by: perekopskiy <53865202+perekopskiy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Storing
protocolVersionas a packed semver value.Two potential improvements:
structin storage. It gives us more explicit description of what it is. However it causes a much bigger diff code and generally packing will still be needed for theprotocolVersionDeadlinemap in STM.Fixes: EVM-637
Why ❔
Checklist