Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port C4 fixes #16

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Port C4 fixes #16

merged 2 commits into from
Nov 3, 2023

Conversation

perekopskiy
Copy link
Collaborator

No description provided.

Copy link

@porteradams12 porteradams12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this matches the c4 fixes

));
let is_delegated_call = common_opcode_state
.decoded_opcode
.properties_bits
.boolean_for_variant(zkevm_opcode_defs::Opcode::FarCall(
zkevm_opcode_defs::FarCallOpcode::Delegate,
.boolean_for_variant(crate::zkevm_opcode_defs::Opcode::FarCall(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why all imports changed from zkevm_opcode_defs to crate::zkevm_opcode_defs?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's now re-exported from zk_evm

@perekopskiy perekopskiy merged commit ed8ab89 into v1.3.3 Nov 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants