This repository has been archived by the owner on Mar 25, 2024. It is now read-only.
Better tests for keccak precompile #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladbochok
reviewed
Nov 3, 2023
test/Keccak256.spec.ts
Outdated
| @@ -39,6 +50,27 @@ describe('Keccak256 tests', function () { | |||
| await keccakTest.zeroPointerTest() | |||
| }); | |||
|
|
|||
| it('general functionality test', async () => { | |||
| // We currently do not have fussing support, so we generate random data using | |||
There was a problem hiding this comment.
Agree that it is non-trivial to integrate Echidna or other Fuzz tooling at the moment. But this test seems to me weird. data is always 32 bytes long. I would rather make a couple of randomly generated tests:
- 0 bytes long
- x *
BLOCK_SIZE- 2 - x *
BLOCK_SIZE- 1 - x *
BLOCK_SIZE - x *
BLOCK_SIZE+ 1 - x *
BLOCK_SIZE+ 2
It is to cover all possible variants of branching
vladbochok
approved these changes
Nov 6, 2023
|
build is likely failing due to the fact that the artifact folder doesnt exist when we run preprocessor. we could likely fix by compiling -> preprocessing -> compiling but IMO it also seems like overkill |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Use the current bytecode in the tests of the keccak precompile and basic randomized inputs
Why ❔
Checklist
zk fmtandzk lint.