Skip to content
This repository has been archived by the owner on Mar 25, 2024. It is now read-only.

Add missing Comments for temporary functions in Bootloader and ContractDeployer #60

Merged

Conversation

vladbochok
Copy link
Member

What ❔

  • Add a comment to the upgradeKeccakIfNeeded function, pointing out that it should be removed once the upgrade process is complete.
  • Add mentioning for temporary upgrade functions that their interdependent counterpart function should also be removed.

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@StanislavBreadless StanislavBreadless merged commit 6903d17 into v1-4-1-integration Nov 21, 2023
5 of 6 checks passed
@StanislavBreadless StanislavBreadless deleted the vb-fix-oz-keccak256-audit-n-01 branch November 21, 2023 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants