feat: l2 gas cli argument #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I feel like the e2e test like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
Introduces a new CLI argument for specifying the L2 gas price.
Why ✋
This is the first step towards dynamic gas parameter fetching. With this PR it's now possible to avoid having to modify the source code when one wants to adjust the L2 gas price.
Evidence 📷
New output of
cargo run --release -- --help:Notes 📝
As the hardcoded L2 gas value can now be overridden it's possible to start a running node with a custom set gas value and run the e2e tests on that node, resulting in a failure of the
zks_estimateFeetest. Maybe we should consider updating e2e-tests/README.md to reflect this change.