Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve system context storage retrieval #216

Merged
merged 3 commits into from
Jan 2, 2024
Merged

fix: improve system context storage retrieval #216

merged 3 commits into from
Jan 2, 2024

Conversation

aon
Copy link

@aon aon commented Jan 2, 2024 •
edited
Loading

What 💻

  • Improves system context storage retrieval
  • Block number and timestamp are being pulled from system context storage, but decoding was done in a wrong way

Why ✋

  • In order to prevent future mistakes decoding system context storage

Evidence 📷

@aon aon requested review from nbaztec and Deniallugo January 2, 2024 17:27
@aon aon changed the title fix: improve inconsistent system context storage retrieval fix: improve system context storage retrieval Jan 2, 2024
Deniallugo
Deniallugo approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@Deniallugo Deniallugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! great improvement!

@nbaztec nbaztec merged commit 5f91581 into main Jan 2, 2024
10 checks passed
@nbaztec nbaztec deleted the aon-fix-swapped-num-and-ts branch January 2, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbaztec nbaztec nbaztec approved these changes

@Deniallugo Deniallugo Deniallugo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aon @nbaztec @Deniallugo