Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: script broadcast error and request memoization on zksolc #269

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

aon
Copy link

@aon aon commented Feb 16, 2024

What 💻

  • Fixes script broadcast deployment when using a private key
  • Upgrades zksolc to v.1.4.0
  • Disables request memoization (zksolc >= v.1.3.3) which allows for modifying system contracts storage on foundry tests

Why ✋

Evidence 📷

image
image

@aon aon requested a review from Karrq February 16, 2024 20:25
@aon aon linked an issue Feb 16, 2024 that may be closed by this pull request
@aon aon marked this pull request as ready for review February 16, 2024 20:31
@Karrq
Copy link
Contributor

Karrq commented Feb 16, 2024

As you said, perhaps overriding the TxEnv instead of passing in the from (to adjust the gas limit) would be nicer, but this works already

@dutterbutter
Copy link
Collaborator

Thanks @aon !

It looks like era-cheatcodes is failing again? It doesnt look like its rate limiting related either?

@aon
Copy link
Author

aon commented Feb 19, 2024

Looks like the CI started failing in #264. I'm checking to see what could possibly change with zksolc 1.3.23 that's making some tests fail.

@aon aon changed the title fix: script broadcast error when using private key fix: script broadcast error and request memoization on zksolc Feb 20, 2024
@aon aon merged commit 320bac6 into main Feb 21, 2024
13 checks passed
@aon aon deleted the fix-script-broadcast-error branch February 21, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vm.envUint("PRIVATE_KEY"); not correctly picking up account
3 participants