Skip to content

Commit

Permalink
feat: Restore commitment test in Boojum integration (#539)
Browse files Browse the repository at this point in the history
## What ❔

Restored commitmenet test

## Why ❔

During Boojum integration the commitment_test was commented out, since
the commitment schema has changed.

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [x] Documentation comments have been added / updated.
- [x] Code has been formatted via `zk fmt` and `zk lint`.
  • Loading branch information
Artemka374 committed Nov 29, 2023
1 parent 8b34ab9 commit 06f510d
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 12 deletions.
2 changes: 0 additions & 2 deletions core/lib/types/src/commitment.rs
Original file line number Diff line number Diff line change
Expand Up @@ -719,8 +719,6 @@ mod tests {
expected_outputs: ExpectedOutput,
}

// TODO(PLA-568): restore this test
#[ignore]
#[test]
fn commitment_test() {
let zksync_home = std::env::var("ZKSYNC_HOME").unwrap_or_else(|_| ".".into());
Expand Down
20 changes: 10 additions & 10 deletions etc/commitment_tests/zksync_testharness_test.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,19 +56,19 @@
]
},
"expected_outputs": {
"l2_l1_bytes": "0000000200000000000000000000000000000000000000000000800b000000000000000000000000000000000000000000000000000000006349f8b557a1099a71e51ea9cce8d89b5a9f1741d3a704e5258077c811223a8b604cdc8a000100000000000000000000000000000000000000008001cb99d29a1b4ffeaefdbf74b8b8b07c78e5e02b3100946f8d0463b79789086aff0000000000000000000000000000000000000000000000000000000000000001",
"l2_l1_linear_hash": "0x680f578a7b39e9f74385a3aabfb4cf054917f23aea9ae165d2afaac02fc9f3b8",
"l2_l1_root_hash": "0xcb5f7b72ab30095b81e2cd35c308a7a752fe59213475339b8a833e91bf731837",
"initial_writes_bytes": "00000002db1231bec2de6342908165662c0d968bb89db1e63211d92fa9547a7efb81499457a1099a71e51ea9cce8d89b5a9f1741d3a704e5258077c811223a8b604cdc8a098c669256db6fe36d87834ceae9c8161af6b72f8b1543b8a3ffacca5b9206af0000000000000000000000000000000000000000000000000000000000000064",
"repeated_writes_bytes": "0000000600000000000002920000000000000000000000000000000c0000000000000000000000000000001f000000000000003d000000000000000000000000000000000000000000000003aec912ce8057d164000000000000003e0000000000000000000000000000000000000000000000000003acf87e3e2200000000000000029400000000000000000000000000000000000000000000000001962afc49a1eb2e0000000000000028000000000000000000000000000000690000000000000000000000006349f8b5000000000000029800000000000000000000000000000000000000000000000000d3abb1bfb7be70",
"repeated_writes_hash": "0xdc5a883793479c779f5c99b0fca910deb20195d8ccf430afad05a9c2bd9f81bd",
"initial_writes_hash": "0xdcc4877ab0c07a79a16ae34de6fb7971a54128db0d11791fd5064bd6d03076c1",
"l2_l1_bytes": "00000000000000000000000000000000000000000000800b000000000000000000000000000000000000000000000000000000006349f8b557a1099a71e51ea9cce8d89b5a9f1741d3a704e5258077c811223a8b604cdc8a000100000000000000000000000000000000000000008001cb99d29a1b4ffeaefdbf74b8b8b07c78e5e02b3100946f8d0463b79789086aff0000000000000000000000000000000000000000000000000000000000000001",
"l2_l1_linear_hash": "0x3735b5ef78a8c9b9a88397148dc68860f183e75ff4e09a2b922554843dff6bde",
"l2_l1_root_hash": "0xf769ef2c8211398f31675bce8797ddc52dac8f4d22606e941a7d7561e1227dd1",
"initial_writes_bytes": "db1231bec2de6342908165662c0d968bb89db1e63211d92fa9547a7efb81499457a1099a71e51ea9cce8d89b5a9f1741d3a704e5258077c811223a8b604cdc8a098c669256db6fe36d87834ceae9c8161af6b72f8b1543b8a3ffacca5b9206af0000000000000000000000000000000000000000000000000000000000000064",
"repeated_writes_bytes": "00000000000002920000000000000000000000000000000c0000000000000000000000000000001f000000000000003d000000000000000000000000000000000000000000000003aec912ce8057d164000000000000003e0000000000000000000000000000000000000000000000000003acf87e3e2200000000000000029400000000000000000000000000000000000000000000000001962afc49a1eb2e0000000000000028000000000000000000000000000000690000000000000000000000006349f8b5000000000000029800000000000000000000000000000000000000000000000000d3abb1bfb7be70",
"repeated_writes_hash": "0xe67f7b247bf84fdbd8a65ab9181343bdc741abac85d783ac9278cc812a76334e",
"initial_writes_hash": "0xa4f52787f13aec574d566ef0d9d8c440b895fb70b74df3758c63da0ff5b47741",
"pass_through_bytes": "000000000000012bbf08d89aaedde3696967d5ac74d2733f10ace64c3a492f503f23b7566b37ab1700000000000000000000000000000000000000000000000000000000000000000000000000000000",
"pass_through_hash": "0x1c695ec7d7944f720a2c0fc6b5651cbd3178967407bc4df579a15985652350e9",
"meta_params_bytes": "000100037723960c07cda7251089daffbdd567476a7e31971ff801568a3856e8e8010006699c833b654b365f0e3ce866c394626d5e40461a6868809d452738606f",
"meta_params_hash": "0x57404e50342edcd09180fb27fa49634676f71a3ce1a76e9b3edf6185bf164082",
"auxiliary_bytes": "cb5f7b72ab30095b81e2cd35c308a7a752fe59213475339b8a833e91bf731837680f578a7b39e9f74385a3aabfb4cf054917f23aea9ae165d2afaac02fc9f3b8dcc4877ab0c07a79a16ae34de6fb7971a54128db0d11791fd5064bd6d03076c1dc5a883793479c779f5c99b0fca910deb20195d8ccf430afad05a9c2bd9f81bd",
"auxiliary_hash": "0x31fff4dc27ee5cbba99aac88a1fd05be00133398b9b7679774663f56b3775dd1",
"commitment_hash": "0x3af4672cd1362badfc0cbc47a7e8b3fbcd3c947055af041b4481bb15009c41a8"
"auxiliary_bytes": "c5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470c5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a47000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
"auxiliary_hash": "0x7c613c82ec911cf56dd6241854dd87bd538e0201f4ff0735f56a1a013db6466a",
"commitment_hash": "0xea55acb8903f82e4cfedd2041ce2db2f3b77741b6e35bc90a4f0a11e9526bfc2"
}
}

0 comments on commit 06f510d

Please sign in to comment.