Skip to content

Commit

Permalink
fix(core): drop correct index of proof_generation_details table durin…
Browse files Browse the repository at this point in the history
…g database migration (#1199)

## What ❔

Fix the problem that dropping the wrong index of the
proof_generation_details table during the migration process.

## Why ❔

In `20230810090211_add_proof_generation_details_table.up.sql`, we create
the `proof_generation_details` table and the
`idx_proof_generation_details_status_prover_taken_at` index.
Symmetrically, we should drop the table and the index in
`20230810090211_add_proof_generation_details_table.down.sql`. But In
fact, the index `idx_l1_batches_status_prover_taken_at` was deleted in
`20230810090211_add_proof_generation_details_table.down.sql`, which was
never created.

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Tests for the changes have been added / updated.
- [x] Documentation comments have been added / updated.
- [x] Code has been formatted via `zk fmt` and `zk lint`.
- [x] Spellcheck has been run via `zk spellcheck`.
- [x] Linkcheck has been run via `zk linkcheck`.
  • Loading branch information
peinlcy committed Mar 19, 2024
1 parent 09b6887 commit 76a6821
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion core/lib/dal/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -117,4 +117,4 @@ resources).
[`zksync_state`]: ../state
[`snapshots_creator`]: ../../bin/snapshots_creator
[`snapshots_applier`]: ../snapshots_applier
[`EXPLAIN`]: https://www.postgresql.org/docs/14/sql-explain.html
[`explain`]: https://www.postgresql.org/docs/14/sql-explain.html
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
DROP TABLE IF EXISTS proof_generation_details;

DROP INDEX IF EXISTS idx_l1_batches_status_prover_taken_at;
DROP INDEX IF EXISTS idx_proof_generation_details_status_prover_taken_at;

0 comments on commit 76a6821

Please sign in to comment.