Skip to content

Commit

Permalink
Remove TODOs comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jorbush committed Feb 23, 2024
1 parent 82efd79 commit c4b6cde
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions core/lib/config/src/testonly.rs
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,6 @@ impl RandomConfig for configs::chain::StateKeeperConfig {
virtual_blocks_per_miniblock: g.gen(),
upload_witness_inputs_to_gcs: g.gen(),
enum_index_migration_chunk_size: g.gen(),
// TODO: this should depend on the mode (Validium or Rollup), but the tests are not adapted yet for this.
l1_batch_commit_data_generator_mode:
configs::chain::L1BatchCommitDataGeneratorMode::Rollup,
}
Expand Down Expand Up @@ -498,7 +497,6 @@ impl RandomConfig for configs::eth_sender::GasAdjusterConfig {
internal_enforced_l1_gas_price: g.gen(),
poll_period: g.gen(),
max_l1_gas_price: g.gen(),
// TODO: this should depend on the mode (Validium or Rollup), but the tests are not adapted yet for this.
l1_gas_per_pubdata_byte: 17,
}
}
Expand Down
2 changes: 0 additions & 2 deletions core/lib/protobuf_config/src/chain.rs
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,6 @@ impl ProtoRepr for proto::StateKeeper {
.transpose()
.context("enum_index_migration_chunk_size")?,
l1_batch_commit_data_generator_mode: required(&self.fee_model_version)
// TODO: this should depend on the mode (Validium or Rollup), but the tests are not adapted yet for this.
.map(|_x| proto::L1BatchCommitDataGeneratorMode::Rollup)
.context("l1_batch_commit_data_generator_mode")?
.parse(),
Expand Down Expand Up @@ -199,7 +198,6 @@ impl ProtoRepr for proto::StateKeeper {
.enum_index_migration_chunk_size
.as_ref()
.map(|x| (*x).try_into().unwrap()),
// TODO: this should depend on the mode (Validium or Rollup), but the tests are not adapted yet for this.
l1_batch_commit_data_generator_mode: Some(
proto::L1BatchCommitDataGeneratorMode::new(
&configs::chain::L1BatchCommitDataGeneratorMode::Rollup,
Expand Down

0 comments on commit c4b6cde

Please sign in to comment.