fix(API): return correct v value for Legacy tx #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deniallugo
reviewed
Oct 4, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
==========================================
+ Coverage 32.72% 32.73% +0.01%
==========================================
Files 536 536
Lines 28125 28129 +4
==========================================
+ Hits 9204 9209 +5
+ Misses 18921 18920 -1
☔ View full report in Codecov by Sentry. |
StanislavBreadless
previously approved these changes
Oct 4, 2023
AnastasiiaVashchuk
requested review from
StanislavBreadless,
Deniallugo and
perekopskiy
perekopskiy
reviewed
Oct 5, 2023
AnastasiiaVashchuk
force-pushed
the
anastasiia-pla-578
branch
from
c6f161b
to
c118035
Compare
Deniallugo
reviewed
Oct 11, 2023
Deniallugo
previously approved these changes
Oct 11, 2023
perekopskiy
reviewed
Oct 11, 2023
perekopskiy
approved these changes
Oct 12, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 12, 2023
🤖 I have created a release *beep* *boop* --- ## [16.0.2](core-v16.0.1...core-v16.0.2) (2023-10-12) ### Bug Fixes * **API:** return correct v value for Legacy tx ([#154](#154)) ([ed502ea](ed502ea)) * **API:** U256 for chainId in api::Transaction struct ([#211](#211)) ([ca98a1c](ca98a1c)) * **prover:** Fix statistic query ([#193](#193)) ([5499093](5499093)) * **state-keeper:** Add L2ToL1LogsCriterion ([#195](#195)) ([64459b2](64459b2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: Danil <deniallugo@gmail.com> Co-authored-by: Danil <deniallugo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.