New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Prover CLI Scaffoldings #1609
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Whilst outside the scope of this PR, I'd suggest we slowly start adding tests over it. It's much easier to integrate at the start, than midway through.
I also noticed that protobuf compatibility is breaking. That's a new job, might've been a fluke. Restarted. If it doesn't pass, we may need to dive deeper there. |
@EmilLuta Sometimes you need just to merge main, I think it is comparing protobuf configs from there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🤖 I have created a release *beep* *boop* --- ## [13.0.0](prover-v12.2.0...prover-v13.0.0) (2024-04-22) ### ⚠ BREAKING CHANGES * **vm:** 1 5 0 support ([#1508](#1508)) ### Features * Archive old prover jobs ([#1516](#1516)) ([201476c](201476c)) * Archiving of prover in gpu_prover_queue ([#1537](#1537)) ([a970629](a970629)) * **configs:** Implement new format of configs and implement protobuf for it ([#1501](#1501)) ([086ba5b](086ba5b)) * **db:** Wrap sqlx errors in DAL ([#1522](#1522)) ([6e9ed8c](6e9ed8c)) * fix availability checker ([#1574](#1574)) ([b2f21fb](b2f21fb)) * Prover CLI Scaffoldings ([#1609](#1609)) ([9a22fa0](9a22fa0)) * Remove zksync-rs SDK ([#1559](#1559)) ([cc78e1d](cc78e1d)) * **sqlx:** Use offline mode by default ([#1539](#1539)) ([af01edd](af01edd)) * **vm:** 1 5 0 support ([#1508](#1508)) ([a6ccd25](a6ccd25)) ### Bug Fixes * **en:** Fix miscellaneous snapshot recovery nits ([#1701](#1701)) ([13bfecc](13bfecc)) * made consensus store certificates asynchronously from statekeeper ([#1711](#1711)) ([d1032ab](d1032ab)) ### Performance Improvements * **merkle tree:** Manage indices / filters in RocksDB ([#1550](#1550)) ([6bbfa06](6bbfa06)) ### Reverts * **env:** Remove `ZKSYNC_HOME` env var from server ([#1713](#1713)) ([aed23e1](aed23e1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: perekopskiy <53865202+perekopskiy@users.noreply.github.com>
tokio = { version = "1", features = ["rt-multi-thread", "macros"] } | ||
env_logger = "0.10" | ||
log = "0.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Is there a reason not to use workspace deps here?
- Why do we need
env_logger
andlog
when we usetracing
andvlog
(ortracing-subscriber
, if you have to) now?
What ❔
This PR implements the scaffolding for a CLI to interact with the prover. Additionally, it integrates the functionality of the
tool
crate.Why ❔
The purpose of this CLI is to simplify the process of interacting with the prover and enhance its usability. Users can easily interact with the prover without requiring specialized insider knowledge, ensuring that it can managed without direct database access and complex manual queries.
Checklist
zk fmt
andzk lint
.zk spellcheck
.zk linkcheck
.