-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: made consensus store certificates asynchronously from statekeeper #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pompon0
changed the title
Made consensus store certificates asynchronously from statekeeper
fix: made consensus store certificates asynchronously from statekeeper
Apr 17, 2024
brunoffranca
previously approved these changes
Apr 17, 2024
brunoffranca
approved these changes
Apr 17, 2024
This was referenced Apr 17, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 22, 2024
🤖 I have created a release *beep* *boop* --- ## [13.0.0](prover-v12.2.0...prover-v13.0.0) (2024-04-22) ### ⚠ BREAKING CHANGES * **vm:** 1 5 0 support ([#1508](#1508)) ### Features * Archive old prover jobs ([#1516](#1516)) ([201476c](201476c)) * Archiving of prover in gpu_prover_queue ([#1537](#1537)) ([a970629](a970629)) * **configs:** Implement new format of configs and implement protobuf for it ([#1501](#1501)) ([086ba5b](086ba5b)) * **db:** Wrap sqlx errors in DAL ([#1522](#1522)) ([6e9ed8c](6e9ed8c)) * fix availability checker ([#1574](#1574)) ([b2f21fb](b2f21fb)) * Prover CLI Scaffoldings ([#1609](#1609)) ([9a22fa0](9a22fa0)) * Remove zksync-rs SDK ([#1559](#1559)) ([cc78e1d](cc78e1d)) * **sqlx:** Use offline mode by default ([#1539](#1539)) ([af01edd](af01edd)) * **vm:** 1 5 0 support ([#1508](#1508)) ([a6ccd25](a6ccd25)) ### Bug Fixes * **en:** Fix miscellaneous snapshot recovery nits ([#1701](#1701)) ([13bfecc](13bfecc)) * made consensus store certificates asynchronously from statekeeper ([#1711](#1711)) ([d1032ab](d1032ab)) ### Performance Improvements * **merkle tree:** Manage indices / filters in RocksDB ([#1550](#1550)) ([6bbfa06](6bbfa06)) ### Reverts * **env:** Remove `ZKSYNC_HOME` env var from server ([#1713](#1713)) ([aed23e1](aed23e1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: perekopskiy <53865202+perekopskiy@users.noreply.github.com>
RomanBrodetski
pushed a commit
that referenced
this pull request
Apr 22, 2024
🤖 I have created a release *beep* *boop* --- ## [23.1.0](core-v23.0.0...core-v23.1.0) (2024-04-22) ### Features * **en:** Add boxed L2 client and use it in DI ([#1627](#1627)) ([9948187](9948187)) * Extract block_reverter into separate crate ([#1632](#1632)) ([8ab2488](8ab2488)) * Extract house keeper into separate crate ([#1685](#1685)) ([f6f49b7](f6f49b7)) * remove enum index migration ([#1734](#1734)) ([13c0f52](13c0f52)) * **state-keeper:** miniblock max payload size (BFT-417) ([#1284](#1284)) ([a3c8e81](a3c8e81)) ### Bug Fixes * **en:** Fix miscellaneous snapshot recovery nits ([#1701](#1701)) ([13bfecc](13bfecc)) * ensure two connections for both executor and async catchup ([#1755](#1755)) ([3b14a9f](3b14a9f)) * made consensus store certificates asynchronously from statekeeper ([#1711](#1711)) ([d1032ab](d1032ab)) * **merkle_tree:** don't panic in `BlockOutputWithProofs::verify_proofs` ([#1717](#1717)) ([a44fac9](a44fac9)) * **types:** fix LegacyCall type ([#1739](#1739)) ([712919f](712919f)) ### Performance Improvements * **en:** Monitor recovery latency by stage ([#1725](#1725)) ([d7efdd5](d7efdd5)) ### Reverts * **env:** Remove `ZKSYNC_HOME` env var from server ([#1713](#1713)) ([aed23e1](aed23e1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: perekopskiy <mikeson.dp@gmail.com> Co-authored-by: perekopskiy <53865202+perekopskiy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far we used a simpler interface where statekeeper was provided the next miniblock only after it persisted the previous one. With the current statekeeper implementation it severely limited the throughput. I've updated consensus API to allow for storing certificates asynchronously to improve the throughput.