Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db): drop constraint prover_jobs_fri_l1_batch_number_fkey #173

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

perekopskiy
Copy link
Contributor

@perekopskiy perekopskiy commented Oct 9, 2023

What ❔

prover_jobs_fri_l1_batch_number_fkey is dropped.

Why ❔

prover_jobs_fri is filled only in prover DB, while l1_batches -- only in core DB, so we can't have the constraint.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@perekopskiy perekopskiy requested a review from a team as a code owner October 9, 2023 07:53
@perekopskiy perekopskiy added this pull request to the merge queue Oct 9, 2023
Merged via the queue into main with commit fa71650 Oct 9, 2023
24 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Oct 11, 2023
🤖 I have created a release *beep* *boop*
---


##
[16.0.0](core-v15.1.1...core-v16.0.0)
(2023-10-11)


### ⚠ BREAKING CHANGES

* **vm:** Update Refund model
([#181](#181))

### Features

* change chainId to u64
([#167](#167))
([f14bf68](f14bf68))
* **merkle tree:** Provide Merkle proofs for tree entries and entry
ranges ([#119](#119))
([1e30d0b](1e30d0b))
* **storage:** save enum indices in RocksDB
([#162](#162))
([bab099d](bab099d))
* **vm:** Update Refund model
([#181](#181))
([92b6f59](92b6f59))


### Bug Fixes

* **db:** drop constraint prover_jobs_fri_l1_batch_number_fkey
([#173](#173))
([fa71650](fa71650))
* **vm:** Make execution status and stop reason public
([#169](#169))
([f98c4fa](f98c4fa))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@perekopskiy perekopskiy deleted the drop-prover_jobs_fri_l1_batch_number_fkey branch April 16, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants