Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vm)!: Update Refund model #181

Merged
merged 1 commit into from
Oct 9, 2023
Merged

feat(vm)!: Update Refund model #181

merged 1 commit into from
Oct 9, 2023

Conversation

Deniallugo
Copy link
Contributor

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@Deniallugo Deniallugo requested a review from a team as a code owner October 9, 2023 15:33
@Deniallugo Deniallugo changed the title feat!(vm): Update Refund model feat(vm)!: Update Refund model Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Attention: 1419 lines in your changes are missing coverage. Please review.

Comparison is base (fe2d6ad) 31.77% compared to head (a66c1fc) 32.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
+ Coverage   31.77%   32.54%   +0.76%     
==========================================
  Files         481      536      +55     
  Lines       25593    28024    +2431     
==========================================
+ Hits         8133     9121     +988     
- Misses      17460    18903    +1443     
Files Coverage Δ
core/lib/multivm/src/glue/block_properties.rs 0.00% <ø> (ø)
core/lib/multivm/src/glue/history_mode.rs 0.00% <ø> (ø)
core/lib/types/src/protocol_version.rs 82.83% <ø> (+2.23%) ⬆️
core/lib/types/src/vm_version.rs 0.00% <ø> (ø)
core/lib/vm/src/tracers/call.rs 50.00% <ø> (ø)
core/lib/vm/src/tracers/storage_invocations.rs 0.00% <ø> (ø)
core/lib/vm/src/tracers/validation/error.rs 0.00% <ø> (ø)
core/lib/vm/src/types/internals/vm_state.rs 51.47% <ø> (ø)
...re/lib/zksync_core/src/api_server/tx_sender/mod.rs 0.00% <ø> (ø)
...ps/vm_virtual_blocks/src/bootloader_state/utils.rs 100.00% <100.00%> (ø)
... and 66 more

... and 49 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Danil <deniallugo@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Detected VM performance changes

Benchmark name Difference in runtime
access_memory +2.0%

@Deniallugo Deniallugo added this pull request to the merge queue Oct 9, 2023
Merged via the queue into main with commit 92b6f59 Oct 9, 2023
30 checks passed
@Deniallugo Deniallugo deleted the deniallugo-fee-model branch October 9, 2023 21:44
github-merge-queue bot pushed a commit that referenced this pull request Oct 11, 2023
🤖 I have created a release *beep* *boop*
---


##
[16.0.0](core-v15.1.1...core-v16.0.0)
(2023-10-11)


### ⚠ BREAKING CHANGES

* **vm:** Update Refund model
([#181](#181))

### Features

* change chainId to u64
([#167](#167))
([f14bf68](f14bf68))
* **merkle tree:** Provide Merkle proofs for tree entries and entry
ranges ([#119](#119))
([1e30d0b](1e30d0b))
* **storage:** save enum indices in RocksDB
([#162](#162))
([bab099d](bab099d))
* **vm:** Update Refund model
([#181](#181))
([92b6f59](92b6f59))


### Bug Fixes

* **db:** drop constraint prover_jobs_fri_l1_batch_number_fkey
([#173](#173))
([fa71650](fa71650))
* **vm:** Make execution status and stop reason public
([#169](#169))
([f98c4fa](f98c4fa))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants