Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(boojnet): various boojnet fixes #462

Merged
merged 10 commits into from
Nov 13, 2023
Merged

fix(boojnet): various boojnet fixes #462

merged 10 commits into from
Nov 13, 2023

Conversation

StanislavBreadless
Copy link
Contributor

@StanislavBreadless StanislavBreadless commented Nov 10, 2023 •
edited by perekopskiy
Loading

What ❔

  • sanity checks for some system log values
  • bug fixed that real proofs can be sent before batches are committed
  • commitment is set only by full tree
  • fix eth_watcher index out of range for EOA-controlled upgrades

Why ❔

bug fixes

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@StanislavBreadless StanislavBreadless requested a review from a team as a code owner November 10, 2023 13:35
perekopskiy
perekopskiy previously approved these changes Nov 10, 2023
View reviewed changes
@ly0va ly0va changed the title add more asserts fix(boojnet): various boojnet fixes Nov 11, 2023
@perekopskiy perekopskiy added this pull request to the merge queue Nov 13, 2023
Merged via the queue into main with commit f13648c Nov 13, 2023
22 checks passed
@perekopskiy perekopskiy deleted the sb-add-more-asserts branch November 13, 2023 11:45
@zksync-era-bot zksync-era-bot mentioned this pull request Nov 13, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 15, 2023
@zksync-era-bot
chore(main): release core 18.0.0 (#424)
44cbb94 
🤖 I have created a release *beep* *boop*
---


##
[18.0.0](core-v17.1.0...core-v18.0.0)
(2023-11-14)


### ⚠ BREAKING CHANGES

* boojum integration
([#112](#112))

### Features

* **basic_witness_input_producer:** Witness inputs queued after BWIP run
([#345](#345))
([9c2be91](9c2be91))
* boojum integration
([#112](#112))
([e76d346](e76d346))
* **core:** adds a get proof endpoint in zks namespace
([#455](#455))
([f4313a4](f4313a4))
* **core:** Split config definitions and deserialization
([#414](#414))
([c7c6b32](c7c6b32))
* **dal:** Do not load config from env in DAL crate
([#444](#444))
([3fe1bb2](3fe1bb2))
* **house_keeper:** Remove GCS Blob Cleaner
([#321](#321))
([9548914](9548914))
* **job-processor:** report attempts metrics
([#448](#448))
([ab31f03](ab31f03))
* **vm:** Use the one interface for all vms
([#277](#277))
([91bb99b](91bb99b))


### Bug Fixes

* **boojnet:** various boojnet fixes
([#462](#462))
([f13648c](f13648c))
* change vks upgrade logic
([#491](#491))
([cb394f3](cb394f3))
* **eth-sender:** Correct ABI for get_verification_key
([#445](#445))
([8af0d85](8af0d85))
* **metadata-calculator:** Save commitment for pre-boojum
([#481](#481))
([664ce33](664ce33))
* Versioned L1 batch metadata
([#450](#450))
([8a40dc3](8a40dc3))
* **vm:** storage_refunds for `vm_refunds_enhancement`
([#449](#449))
([1e1e59f](1e1e59f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perekopskiy perekopskiy perekopskiy approved these changes

@Deniallugo Deniallugo Awaiting requested review from Deniallugo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@StanislavBreadless @perekopskiy @ly0va