feat(vm): Use the one interface for all vms #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
==========================================
+ Coverage 35.85% 35.96% +0.10%
==========================================
Files 519 525 +6
Lines 27828 27811 -17
==========================================
+ Hits 9978 10002 +24
+ Misses 17850 17809 -41
☔ View full report in Codecov by Sentry. |
Deniallugo
force-pushed
the
deniallugo-vm-interface
branch
from
b5c2340
to
8b2dd90
Compare
Signed-off-by: Danil <deniallugo@gmail.com>
Deniallugo
force-pushed
the
deniallugo-vm-interface
branch
from
624c8bd
to
b0cf6e2
Compare
montekki
reviewed
Oct 26, 2023
Signed-off-by: Danil <deniallugo@gmail.com>
Deniallugo
force-pushed
the
deniallugo-vm-interface
branch
from
a566038
to
44a41f0
Compare
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
Signed-off-by: Danil <deniallugo@gmail.com>
popzxc
reviewed
Nov 1, 2023
core/lib/multivm/src/versions/vm_virtual_blocks/tracers/dispatcher.rs
Outdated
Show resolved
Hide resolved
Signed-off-by: Danil <deniallugo@gmail.com>
Deniallugo
force-pushed
the
deniallugo-vm-interface
branch
from
a37dafe
to
a5279b4
Compare
popzxc
previously approved these changes
Nov 1, 2023
perekopskiy
previously approved these changes
Nov 1, 2023
Signed-off-by: Danil <deniallugo@gmail.com>
popzxc
previously approved these changes
Nov 3, 2023
Deniallugo
force-pushed
the
deniallugo-vm-interface
branch
from
1a98417
to
c709967
Compare
Signed-off-by: Danil <deniallugo@gmail.com>
Deniallugo
force-pushed
the
deniallugo-vm-interface
branch
from
c709967
to
aaf24a9
Compare
popzxc
previously approved these changes
Nov 7, 2023
popzxc
approved these changes
Nov 7, 2023
Detected VM performance changes
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 15, 2023
🤖 I have created a release *beep* *boop* --- ## [18.0.0](core-v17.1.0...core-v18.0.0) (2023-11-14) ### ⚠ BREAKING CHANGES * boojum integration ([#112](#112)) ### Features * **basic_witness_input_producer:** Witness inputs queued after BWIP run ([#345](#345)) ([9c2be91](9c2be91)) * boojum integration ([#112](#112)) ([e76d346](e76d346)) * **core:** adds a get proof endpoint in zks namespace ([#455](#455)) ([f4313a4](f4313a4)) * **core:** Split config definitions and deserialization ([#414](#414)) ([c7c6b32](c7c6b32)) * **dal:** Do not load config from env in DAL crate ([#444](#444)) ([3fe1bb2](3fe1bb2)) * **house_keeper:** Remove GCS Blob Cleaner ([#321](#321)) ([9548914](9548914)) * **job-processor:** report attempts metrics ([#448](#448)) ([ab31f03](ab31f03)) * **vm:** Use the one interface for all vms ([#277](#277)) ([91bb99b](91bb99b)) ### Bug Fixes * **boojnet:** various boojnet fixes ([#462](#462)) ([f13648c](f13648c)) * change vks upgrade logic ([#491](#491)) ([cb394f3](cb394f3)) * **eth-sender:** Correct ABI for get_verification_key ([#445](#445)) ([8af0d85](8af0d85)) * **metadata-calculator:** Save commitment for pre-boojum ([#481](#481)) ([664ce33](664ce33)) * Versioned L1 batch metadata ([#450](#450)) ([8a40dc3](8a40dc3)) * **vm:** storage_refunds for `vm_refunds_enhancement` ([#449](#449)) ([1e1e59f](1e1e59f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
toni-calvin
referenced
this pull request
in lambdaclass/zksync-era
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Implement one common interface for all vms. It's the first attempt to do it and it's done only for two latest vms.
In the future all vms will be migrated to the one interface.
Why ❔
We need to unify our work with VM now it's always unpredicable what are we calling and when
p.s. I'm not going to merge it before boojum
The thing, i don't like:
Using
vm_latest::HistoryEenablein interface.It suppose to take another Eternity to refactor HistoryMode
Checklist
zk fmtandzk lint.