feat: Better errors for JsonRPC calls #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slowli
reviewed
Feb 5, 2024
slowli
previously approved these changes
Feb 8, 2024
tomg10
force-pushed
the
en-rpc-context
branch
from
b1cbce3
to
c7d03e7
Compare
Signed-off-by: tomg10 <lemures64@gmail.com>
Signed-off-by: tomg10 <lemures64@gmail.com>
Signed-off-by: tomg10 <lemures64@gmail.com>
Signed-off-by: tomg10 <lemures64@gmail.com>
Signed-off-by: tomg10 <lemures64@gmail.com>
tomg10
force-pushed
the
en-rpc-context
branch
from
c7d03e7
to
34d968c
Compare
| formatter.write_str(", ")?; | ||
| } | ||
| } | ||
| formatter.write_str(")") |
There was a problem hiding this comment.
just curious - could we do something like .join(", ") here? Did you want to avoid allocating a vector for this?
There was a problem hiding this comment.
Yes, it's an additional allocation that can be easily avoided.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 16, 2024
🤖 I have created a release *beep* *boop* --- ## [20.7.0](core-v20.6.0...core-v20.7.0) (2024-02-16) ### Features * Add input field to CallRequest ([#1069](#1069)) ([5087121](5087121)) * **api:** Remove unused and obsolete token info ([#1071](#1071)) ([e920897](e920897)) * Better errors for JsonRPC calls ([#1002](#1002)) ([079f999](079f999)) * **commitment:** Commitment component ([#1024](#1024)) ([60305ba](60305ba)) * **en:** Make snapshots applier resilient and process storage log chunks in parallel ([#1036](#1036)) ([805218c](805218c)) * **node_framework:** Resources and layers for ETH clients ([#1074](#1074)) ([776337a](776337a)) * **node_framework:** Support StateKeeper in the framework ([#1043](#1043)) ([a80fff2](a80fff2)) ### Bug Fixes * **api:** Return on duplicate earlier ([#1059](#1059)) ([cfa5701](cfa5701)) * **contract-verifier:** Use optimizer mode in solidity-single-file verification ([#1079](#1079)) ([fdab638](fdab638)) * Token distribution ([#1051](#1051)) ([bd63b3a](bd63b3a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Provides additional context for JSON-RPC client calls used by the EN with the help of an extension trait.
Why ❔
Some of client errors are currently quite obscure and thus difficult to debug.
Checklist
zk fmtandzk lint.zk spellcheck.zk linkcheck.