Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(prover): Fixing snark verification keys #1225

Merged
merged 7 commits into from
Mar 6, 2024
Merged

feat(prover): Fixing snark verification keys #1225

merged 7 commits into from
Mar 6, 2024

Conversation

mm-zk
Copy link
Collaborator

@mm-zk mm-zk commented Feb 23, 2024 •
edited
Loading

What ❔

  • Compute the snark verification key in rust code
  • Added historical values and tests to make sure that computations are correct
  • Write the small json file with commitments when generating new verification key.
  • Stopped loading CONTRACTS_SNARK_WRAPPER_VK_HASH from env variable, and computing it locally instead.

Why ❔

  • In the past, the snark verification key generation was a complex process, that involved running a separate binaries
  • Now it is all the part of the key generator, with a simple utils library (and without including the old test harness)
  • Historical files will allow us to quickly check the correctness of the older blocks

@mm-zk mm-zk requested review from ly0va and EmilLuta February 23, 2024 09:42
@mm-zk mm-zk marked this pull request as ready for review February 23, 2024 09:42
@mm-zk mm-zk requested a review from koloz193 March 6, 2024 15:05
EmilLuta
EmilLuta approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@EmilLuta EmilLuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing my slips, appreciate that!

@mm-zk mm-zk enabled auto-merge March 6, 2024 15:51
@mm-zk mm-zk added this pull request to the merge queue Mar 6, 2024
Merged via the queue into main with commit 5cbef73 Mar 6, 2024
34 of 35 checks passed
@mm-zk mm-zk deleted the mmzk0223_fixing_vk_commitments branch March 6, 2024 16:20
@zksync-era-bot zksync-era-bot mentioned this pull request Mar 6, 2024
Merged
RomanBrodetski pushed a commit that referenced this pull request Mar 12, 2024
@zksync-era-bot
chore(main): release prover 12.1.0 (#1363)
1d3edab 
🤖 I have created a release *beep* *boop*
---


##
[12.1.0](prover-v12.0.1...prover-v12.1.0)
(2024-03-12)


### Features

* add run-observability to zk
([#1359](#1359))
([2b520f6](2b520f6))
* block revert support for consensus component
([#1213](#1213))
([8a3a938](8a3a938))
* enhance unit test for batch tip
([#1253](#1253))
([ca7d194](ca7d194))
* Moving 1.4.x to use the circuit_api
([#1383](#1383))
([8add2d6](8add2d6))
* **prover:** Fixing snark verification keys
([#1225](#1225))
([5cbef73](5cbef73))
* replacing 1.3.3 test harness with circuit sequencer api
([#1382](#1382))
([a628d56](a628d56))
* Start using a new test harness interface without generics
([#1378](#1378))
([1e431a6](1e431a6))


### Bug Fixes

* **api:** SQL: use = instead of ANY where possible in events-related
queries ([#1346](#1346))
([160b4d4](160b4d4))
* Updated Verification keys
([#1414](#1414))
([66667d2](66667d2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koloz193 koloz193 koloz193 approved these changes

@EmilLuta EmilLuta EmilLuta approved these changes

@ly0va ly0va Awaiting requested review from ly0va

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mm-zk @koloz193 @EmilLuta