fix(Validium): Remove obscure use of VALIDIUM_MODE env
#1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
…idium_mode_env_usage
popzxc
reviewed
Feb 26, 2024
6 tasks
…daClass/zksync-era into feat_remove_validium_mode_env_usage
…Class/zksync-era into feat_remove_validium_mode_env_usage
6 tasks
…-labs/zksync-era into feat_remove_validium_mode_env_usage
…-labs/zksync-era into feat_remove_validium_mode_env_usage
…-labs/zksync-era into feat_remove_validium_mode_env_usage
…-labs/zksync-era into feat_remove_validium_mode_env_usage
ilitteri
merged commit 51875a3
into
matter-labs:feat_validium_pubdata_abstraction
34 of 36 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer⚠️
This PR has a counterpart in the
era-contractsrepo. The PR in question is matter-labs/era-contracts#225. Theera-contractssubmodule is pointing to said PR's branch. Before merging this PR, after it is approved and theera-contractscounterpart is merged, we need to update this PR's submodule commit.What ❔
This PR removes the use of
VALIDIUM_MODEenv for the contracts side and replaces it with the passthrough of the flag to thel1-contractsdeploy script.Why ❔
zktool is settingVALIDIUM_MODEenvironment variable, which is only used by a script in a different repository (era-contracts). This is a very implicit and hard to track approach.Checklist
zk fmtandzk lint.zk spellcheck.zk linkcheck.