feat(Gas Oracle): Conversion rate component #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popzxc
reviewed
Mar 8, 2024
Comment on lines
35
to
36
| let mut rng = rand::thread_rng(); | ||
| let random_number: u64 = rng.gen_range(1..=100); |
There was a problem hiding this comment.
I think it'll be too volatile for any actual usage. Let's hardcode this as a const for now and later alter the logic as soon as it's needed.
There was a problem hiding this comment.
Addressed in latest commit:
async fn get_conversion_rate(extract::Path(_token_address): extract::Path<String>) -> Json<u64> {
tracing::info!("Received request for conversion rate");
Json(42)
}
core/lib/zksync_core/src/lib.rs
Outdated
Comment on lines
239
to
240
| /// Conversion rate API, for local development. | ||
| ConversionRateApi, |
There was a problem hiding this comment.
I think it makes sense to prepend it with Dev here and everywhere else to clearly indicate that it's a local development utility and not something that is needed for production.
popzxc
reviewed
Mar 11, 2024
| // basic handler that responds with a static string | ||
| async fn get_conversion_rate(extract::Path(_token_address): extract::Path<String>) -> Json<u64> { | ||
| tracing::info!("Received request for conversion rate"); | ||
| Json(42) |
core/lib/zksync_core/src/lib.rs
Outdated
| @@ -270,6 +273,7 @@ impl FromStr for Components { | |||
| "eth_tx_manager" => Ok(Components(vec![Component::EthTxManager])), | |||
| "proof_data_handler" => Ok(Components(vec![Component::ProofDataHandler])), | |||
| "native_token_fetcher" => Ok(Components(vec![Component::NativeTokenFetcher])), | |||
| "conversion_rate_api" => Ok(Components(vec![Component::DevConversionRateApi])), | |||
There was a problem hiding this comment.
conversion_rate_api -> dev_conversion_rate_api
core/lib/zksync_core/src/lib.rs
Outdated
| @@ -76,6 +76,7 @@ use crate::{ | |||
| }, | |||
| }; | |||
|
|
|||
| pub mod api_conversion_rate; | |||
There was a problem hiding this comment.
api_conversion_rate -> dev_api_conversion_rate
popzxc
approved these changes
Mar 11, 2024
jrchatruc
changed the title
jrchatruc
merged commit feaf132
into
matter-labs:lambdaclass_gas_oracle
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist
zk fmtandzk lint.zk spellcheck.zk linkcheck.