feat: enabled loading yaml config for the main node #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pompon0
changed the title
Deniallugo
previously approved these changes
Mar 5, 2024
|
Although we have this fellow. This was added as a quick fix to make it possible to not have a private key in each env we use, not sure if this in or out of scope for this PR. |
I'd say it's out of scope and i'll move it to secret part |
…/zksync-era into gprusak-server-config
Deniallugo
approved these changes
Mar 6, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
🤖 I have created a release *beep* *boop* --- ## [21.1.0](core-v21.0.0...core-v21.1.0) (2024-03-13) ### Features * **api:** Monitor server RPC errors ([#1203](#1203)) ([60d1060](60d1060)) * block revert support for consensus component ([#1213](#1213)) ([8a3a938](8a3a938)) * **db:** Add Postgres table size metrics ([#1351](#1351)) ([63f3ff8](63f3ff8)) * **db:** Serialize events queue as bytes ([#1420](#1420)) ([955680b](955680b)) * enabled loading yaml config for the main node ([#1344](#1344)) ([0adab9e](0adab9e)) * **en:** Enable Merkle tree client on EN ([#1386](#1386)) ([58576d1](58576d1)) * enhance unit test for batch tip ([#1253](#1253)) ([ca7d194](ca7d194)) * Moving 1.4.x to use the circuit_api ([#1383](#1383)) ([8add2d6](8add2d6)) * **node_framework:** Add timeouts for remaining tasks to avoid hang outs ([#1354](#1354)) ([8108dbd](8108dbd)) * **node-framework:** Add commitment generator layer ([#1402](#1402)) ([daa029c](daa029c)) * replacing 1.3.3 test harness with circuit sequencer api ([#1382](#1382)) ([a628d56](a628d56)) ### Bug Fixes * **aggregator:** correct order of processing of prove transactions ([#1333](#1333)) ([7522d15](7522d15)) * **api:** Fix panics in API server if storage values cache is disabled ([#1370](#1370)) ([723232b](723232b)) * **api:** SQL: use = instead of ANY where possible in events-related queries ([#1346](#1346)) ([160b4d4](160b4d4)) * **consistency_checker:** Fix consistency checker for large pubdata ([#1331](#1331)) ([d162add](d162add)) * **en:** Fix pending transactions subscription ([#1342](#1342)) ([a040001](a040001)) * **eth-sender:** adjust the blob tx fees taking into account the current prices ([#1399](#1399)) ([fea67fb](fea67fb)) * **gas-adjuster:** Do not unwrap in gas-adjuster ([#1400](#1400)) ([269812e](269812e)) * **gas-adjuster:** Use `internal_pubdata_pricing_multiplier` for pubdata price calculation ([#1404](#1404)) ([a40c2d0](a40c2d0)) ### Performance Improvements * **db:** Add "contains" clause for get_logs ([#1384](#1384)) ([e62ae32](e62ae32)) * **db:** Remove obsolete indexes ([#1376](#1376)) ([0afc377](0afc377)) ### Reverts * **db:** Remove "contains" clause for get_logs ([#1384](#1384)) ([#1407](#1407)) ([1da53f3](1da53f3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added config_path flag to the main node binary.
If set, binary will load the config from a yaml file instead of env vars.
I've moved each proto descriptor file to its own package, because prost seems to be unable to import package from multiple files.
I've moved secrets out of TempConfigStore, so that they are delivered separately.