Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hardcode initial chain id #1581

Merged
merged 1 commit into from
Apr 5, 2024
Merged

hardcode initial chain id #1581

merged 1 commit into from
Apr 5, 2024

Conversation

Deniallugo
Copy link
Contributor

@Deniallugo Deniallugo commented Apr 5, 2024 •
edited

What ❔

All chains are initialized with the same chain id, and then we have to set it properly.
It was hardcoded in scripts before, now it moved to server

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@Deniallugo
feat(init): hardcode initial chain id
3e59eb1 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo Deniallugo requested a review from a team as a code owner April 5, 2024 08:03
@Deniallugo Deniallugo changed the base branch from main to kl-factory April 5, 2024 08:03
@Deniallugo Deniallugo requested a review from kelemeno April 5, 2024 08:05
@Deniallugo Deniallugo changed the title hardcode initial chain hardcode initial chain id Apr 5, 2024
@kelemeno kelemeno merged commit 930eb77 into kl-factory Apr 5, 2024
22 of 42 checks passed
@kelemeno kelemeno deleted the deniallugo-hardcode-initial-chain-id branch April 5, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorik yorik Awaiting requested review from yorik yorik was automatically assigned from matter-labs/devops

@alexandrst88 alexandrst88 Awaiting requested review from alexandrst88 alexandrst88 was automatically assigned from matter-labs/devops

@artmakh artmakh Awaiting requested review from artmakh artmakh was automatically assigned from matter-labs/devops

@hatemosphere hatemosphere Awaiting requested review from hatemosphere hatemosphere was automatically assigned from matter-labs/devops

@onyxet onyxet Awaiting requested review from onyxet onyxet was automatically assigned from matter-labs/devops

@otani88 otani88 Awaiting requested review from otani88 otani88 was automatically assigned from matter-labs/devops

@kelemeno kelemeno Awaiting requested review from kelemeno

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Deniallugo @kelemeno