ci: CI for shared bridge #1604
Merged
ci: CI for shared bridge #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ly0va
requested review from
yorik,
alexandrst88,
artmakh,
hatemosphere,
onyxet and
otani88
and removed request for
a team
mm-zk
approved these changes
Apr 12, 2024
| @@ -59,7 +59,7 @@ jobs: | |||
| ci_run zk contract build | |||
|
|
|||
| - name: Contracts unit tests | |||
| run: ci_run zk test l1-contracts | |||
| run: ci_run yarn l1-contracts test | |||
There was a problem hiding this comment.
let's then remove the 'l1-contracts' from zk test..
(infrastructure/tests.ts)
| Local, | ||
| Version24, |
There was a problem hiding this comment.
yes! otherwise upgrade unit tests fail. There was a comment about it sometime ago, but apparently it was removed during merge
| max_pubdata_per_batch = 100000 | ||
| fee_model_version = "V2" | ||
| l1_batch_commit_data_generator_mode = "Validium" | ||
| miniblock_iteration_interval = 50 |
There was a problem hiding this comment.
why is this here for docker?
There was a problem hiding this comment.
this was merged in from main.
but we decided to disable validium tests in ci for now, so shouldn't matter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist
zk fmtandzk lint.zk spellcheck.zk linkcheck.