fix: Fixing issues with lint #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes EVM-560
mm-zk
requested review from
yorik,
alexandrst88,
artmakh,
hatemosphere,
onyxet and
otani88
and removed request for
a team
ly0va
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
LGTM. Perhaps we want to keep it this way actually? IMO sol linting and formatting should already be checked when pushed to era-contracts.
And even if it's not linted / formatted properly here, fixing it would require us to push to era-contracts and bump submodule here, which is much more work than a zk fmt & commit like for other file formats. So perhaps it's easier to enforce formatting of .sol's only in the era-contracts ci.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EVM-560 - but still keeps '.sol' files disabled.
What ❔