fix: More migration fixes, bumping contracts #1694
Conversation
kelemeno
changed the title
…l/factory-migration-fix
…l/factory-migration-fix
between branches for the upgrade
…l/factory-migration-fix
…l/factory-migration-fix
| "license": "MIT", | ||
| "private": true, | ||
| "scripts": { | ||
| "test": "zk f jest --forceExit --testTimeout 120000", |
There was a problem hiding this comment.
also, why did we change the padding for this file?
There was a problem hiding this comment.
I just changed the padding because it also changed in kl-factory, so just changing it back.
the 120k is an error, will fix
There was a problem hiding this comment.
docs/specs/zk_evm/vm_specification/compiler/instructions/evm/environment.md
Outdated
Show resolved
Hide resolved
| @@ -58,6 +61,21 @@ async function hyperchainUpgrade1() { | |||
| ); | |||
| } | |||
|
|
|||
| async function insertAddresses() { | |||
There was a problem hiding this comment.
why do we need it? we will have the new facets deployed and they would be written to the facets.json
There was a problem hiding this comment.
I am using a different deployment script, because we also need to deploy the STM, Bridgehub, and other contracts, and we need to set the initial diamond cut in the STM. Doing this seemed easier.
Co-authored-by: Stanislav Bezkorovainyi <stanislavbezkor@gmail.com>
Co-authored-by: Stanislav Bezkorovainyi <stanislavbezkor@gmail.com>
…l/factory-migration-fix
Detected VM performance changes
Changes in number of opcodes executed indicate that the gas price of the benchmark has changed, which causes it run out of gas at a different time. Or that it is behaving completely differently. |
What ❔
Why ❔
Checklist
zk fmtandzk lint.zk spellcheck.zk linkcheck.