refactor: Rename miniblock to l2 block – base + state keeper #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slowli
force-pushed
the
aov-pla-882-rename-miniblock-to-l2-block
branch
from
da7372f
to
41527ba
Compare
|
May be obvious: if this approach is OK, I plan to create smaller follow-up PRs to change naming in other components. |
perekopskiy
approved these changes
Apr 18, 2024
6 tasks
|
I love the idea. I wonder, how can we backfill things that are leftover (as you mentioned DB, APIs, etc.) This is a question for a broader group, though. cc: @RomanBrodetski |
6 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 19, 2024
## What ❔ Renames "miniblock" to "L2 block" in libraries (i.e., `core/lib` crates with the exception of `zksync_core`). ## Why ❔ See #1696 for reasoning. ## Checklist - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`. - [x] Spellcheck has been run via `zk spellcheck`. - [x] Linkcheck has been run via `zk linkcheck`.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
## What ❔ Renames "miniblock" to "L2 block" in core components (ones remaining in `zksync_core`). ## Why ❔ See #1696 for reasoning. ## Checklist - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`. - [x] Spellcheck has been run via `zk spellcheck`. - [x] Linkcheck has been run via `zk linkcheck`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Renames "miniblock" to "L2 block" in types, DAL and state keeper.
Why ❔
Checklist
zk fmtandzk lint.zk spellcheck.zk linkcheck.