Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixing local node #1708

Merged
merged 4 commits into from
Apr 17, 2024
Merged

fix: Fixing local node #1708

merged 4 commits into from
Apr 17, 2024

Conversation

mm-zk
Copy link
Collaborator

@mm-zk mm-zk commented Apr 17, 2024

What ❔

  • Fixing docker build and scripts for the local node/setup.

Why ❔

  • This will allow local node to work again - which is crucial before the bridgehub udpate.
  • This PR is only fixing it in the 'main' branch - there will be a followup PR to the bridgehub branch coming later.

@mm-zk mm-zk requested a review from a team as a code owner April 17, 2024 06:31
ly0va
ly0va previously approved these changes Apr 17, 2024
View reviewed changes
docker/local-node/entrypoint.sh Outdated Show resolved Hide resolved
RomanBrodetski
RomanBrodetski approved these changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@RomanBrodetski RomanBrodetski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't see anything suspicious

yorik
yorik approved these changes Apr 17, 2024
View reviewed changes
docker/local-node/Dockerfile Show resolved Hide resolved
@mm-zk mm-zk added this pull request to the merge queue Apr 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 17, 2024
@mm-zk mm-zk added this pull request to the merge queue Apr 17, 2024
Merged via the queue into main with commit ea6b24e Apr 17, 2024
40 of 41 checks passed
@mm-zk mm-zk deleted the mmzk_0416_local_node branch April 17, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorik yorik yorik approved these changes

@RomanBrodetski RomanBrodetski RomanBrodetski approved these changes

@ly0va ly0va ly0va approved these changes

@alexandrst88 alexandrst88 Awaiting requested review from alexandrst88 alexandrst88 is a code owner automatically assigned from matter-labs/devops

@artmakh artmakh Awaiting requested review from artmakh artmakh is a code owner automatically assigned from matter-labs/devops

@hatemosphere hatemosphere Awaiting requested review from hatemosphere hatemosphere is a code owner automatically assigned from matter-labs/devops

@onyxet onyxet Awaiting requested review from onyxet onyxet is a code owner automatically assigned from matter-labs/devops

@otani88 otani88 Awaiting requested review from otani88 otani88 is a code owner automatically assigned from matter-labs/devops

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mm-zk @yorik @RomanBrodetski @ly0va