Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding local-node support for bridgehub #1715

Merged
merged 9 commits into from
Apr 19, 2024
Merged

feat: Adding local-node support for bridgehub #1715

merged 9 commits into from
Apr 19, 2024

Conversation

mm-zk
Copy link
Collaborator

@mm-zk mm-zk commented Apr 17, 2024 •
edited
Loading

What ❔

  • Fixing local node - now it will work with bridgehub
  • Fixes EVM-564

Why ❔

  • This will allow easy testing.
  • In the next PRs, I'll introduce ways to create local-node with custom base token and with validiums.

@mm-zk mm-zk requested a review from a team as a code owner April 17, 2024 12:30
@mm-zk mm-zk requested review from yorik, alexandrst88, artmakh, hatemosphere, onyxet, otani88, ly0va and benceharomi and removed request for a team April 17, 2024 12:30
ly0va
ly0va approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@ly0va ly0va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some kind of CI for local node as well? Just to be sure that it builds & runs at least

@mm-zk mm-zk merged commit 82d7f2f into kl-factory Apr 19, 2024
41 checks passed
@mm-zk mm-zk deleted the mmzk_0417_localsetup_kl_factory branch April 19, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ly0va ly0va ly0va approved these changes

@benceharomi benceharomi benceharomi approved these changes

@yorik yorik Awaiting requested review from yorik yorik was automatically assigned from matter-labs/devops

@alexandrst88 alexandrst88 Awaiting requested review from alexandrst88 alexandrst88 was automatically assigned from matter-labs/devops

@artmakh artmakh Awaiting requested review from artmakh artmakh was automatically assigned from matter-labs/devops

@hatemosphere hatemosphere Awaiting requested review from hatemosphere hatemosphere was automatically assigned from matter-labs/devops

@onyxet onyxet Awaiting requested review from onyxet onyxet was automatically assigned from matter-labs/devops

@otani88 otani88 Awaiting requested review from otani88 otani88 was automatically assigned from matter-labs/devops

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mm-zk @ly0va @benceharomi