Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed ethers.test for ETH based chain. #1742

Merged
merged 3 commits into from
Apr 19, 2024
Merged

fix: fixed ethers.test for ETH based chain. #1742

merged 3 commits into from
Apr 19, 2024

Conversation

mm-zk
Copy link
Collaborator

@mm-zk mm-zk commented Apr 19, 2024

What ❔

  • Fixed ethers.test for ETH based chains.
  • Minimised the diff against 'main' branch.

Why ❔

  • Before, the test was depending on local env variables (to check if L2 was a ETH or custom based).
  • also it didn't pass the proper arguments to the estimate method.

@mm-zk mm-zk merged commit bf7c867 into kl-factory Apr 19, 2024
35 checks passed
@mm-zk mm-zk deleted the mmzk_0419_fixing_ethers_test branch April 19, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanislavBreadless StanislavBreadless StanislavBreadless approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mm-zk @StanislavBreadless