Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: kl-factory revert test #1744

Merged
merged 11 commits into from
Apr 22, 2024
Merged

fix: kl-factory revert test #1744

merged 11 commits into from
Apr 22, 2024

Conversation

Raid5594
Copy link
Collaborator

@Raid5594 Raid5594 commented Apr 19, 2024 •
edited
Loading

What ❔

Fixing the reverter test.
Fixes EVM-539

Why ❔

Updates related to shared bridge.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@Raid5594 Raid5594 requested a review from a team as a code owner April 19, 2024 14:16
@Raid5594 Raid5594 requested review from yorik, alexandrst88, artmakh, hatemosphere, onyxet and otani88 and removed request for a team April 19, 2024 14:16
@Raid5594 Raid5594 requested a review from mm-zk April 19, 2024 16:19
@kelemeno kelemeno merged commit 4704f19 into kl-factory Apr 22, 2024
35 checks passed
@kelemeno kelemeno deleted the kl-factory-revert-test branch April 22, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanislavBreadless StanislavBreadless StanislavBreadless approved these changes

@yorik yorik Awaiting requested review from yorik yorik is a code owner automatically assigned from matter-labs/devops

@alexandrst88 alexandrst88 Awaiting requested review from alexandrst88 alexandrst88 is a code owner automatically assigned from matter-labs/devops

@artmakh artmakh Awaiting requested review from artmakh artmakh is a code owner automatically assigned from matter-labs/devops

@hatemosphere hatemosphere Awaiting requested review from hatemosphere hatemosphere is a code owner automatically assigned from matter-labs/devops

@onyxet onyxet Awaiting requested review from onyxet onyxet is a code owner automatically assigned from matter-labs/devops

@otani88 otani88 Awaiting requested review from otani88 otani88 is a code owner automatically assigned from matter-labs/devops

@mm-zk mm-zk Awaiting requested review from mm-zk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Raid5594 @StanislavBreadless @kelemeno