Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(kl-factory): Respond to comments by mm-zk #1756

Merged
merged 4 commits into from
Apr 22, 2024
Merged

chore(kl-factory): Respond to comments by mm-zk #1756

merged 4 commits into from
Apr 22, 2024

Conversation

StanislavBreadless
Copy link
Contributor

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@StanislavBreadless StanislavBreadless requested a review from a team as a code owner April 22, 2024 12:07
@StanislavBreadless StanislavBreadless requested review from yorik, alexandrst88, artmakh, hatemosphere, onyxet and otani88 and removed request for a team April 22, 2024 12:07
@StanislavBreadless StanislavBreadless changed the title Respond to comments by mm-zk chore(kl-factory): Respond to comments by mm-zk Apr 22, 2024
@StanislavBreadless StanislavBreadless merged commit 9ef148e into kl-factory Apr 22, 2024
42 checks passed
@StanislavBreadless StanislavBreadless deleted the sb-respond-to-mm-zk branch April 22, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mm-zk mm-zk mm-zk approved these changes

@yorik yorik Awaiting requested review from yorik yorik is a code owner automatically assigned from matter-labs/devops

@alexandrst88 alexandrst88 Awaiting requested review from alexandrst88 alexandrst88 is a code owner automatically assigned from matter-labs/devops

@artmakh artmakh Awaiting requested review from artmakh artmakh is a code owner automatically assigned from matter-labs/devops

@hatemosphere hatemosphere Awaiting requested review from hatemosphere hatemosphere is a code owner automatically assigned from matter-labs/devops

@onyxet onyxet Awaiting requested review from onyxet onyxet is a code owner automatically assigned from matter-labs/devops

@otani88 otani88 Awaiting requested review from otani88 otani88 is a code owner automatically assigned from matter-labs/devops

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@StanislavBreadless @mm-zk