Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add test for migration #1765

Merged
merged 5 commits into from
Apr 23, 2024

Conversation

StanislavBreadless
Copy link
Contributor

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@StanislavBreadless StanislavBreadless changed the title add test for migration Add test for migration Apr 22, 2024
@kelemeno kelemeno changed the title Add test for migration fix: Add test for migration Apr 22, 2024
@kelemeno
Copy link
Contributor

To merge I want to wait for:
matter-labs/era-contracts#390
so that we can bump the contracts, and that so that CI passes.

Copy link
Contributor

Detected VM performance changes

Benchmark name change in estimated runtime change in number of opcodes executed
finish_eventful_frames N/A +93 (+0.0%)
decode_shl_sub N/A +144 (+0.0%)
write_and_decode N/A +155 (+0.0%)
event_spam N/A +134 (+0.0%)
call_far N/A +85 (+0.0%)
deploy_simple_contract N/A +81 (+0.5%)
slot_hash_collision N/A +155 (+0.0%)
access_memory N/A +155 (+0.0%)

Changes in number of opcodes executed indicate that the gas price of the benchmark has changed, which causes it run out of gas at a different time. Or that it is behaving completely differently.

@StanislavBreadless StanislavBreadless merged commit fc2a3ed into kl-factory Apr 23, 2024
42 checks passed
@StanislavBreadless StanislavBreadless deleted the sb-fix-migration-to-kl-factory branch April 23, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants